Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-19] [TS migration] Migrate 'FlagComment' page to TypeScript #25184

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 18 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 NewFeature Something to build that is a new item. Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/FlagCommentPage.js 22
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@ruben-rebelo
Copy link
Contributor

I am Ruben Rebelo from Callstack - expert contributor group. I’d like to work on this job.

@melvin-bot melvin-bot bot added the Overdue label Jan 17, 2024
Copy link
Author

melvin-bot bot commented Jan 17, 2024

📣 @ruben-rebelo! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Copy link
Author

melvin-bot bot commented Feb 6, 2024

Triggered auto assignment to @danieldoglas, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Feb 8, 2024
Copy link
Author

melvin-bot bot commented Feb 8, 2024

@danieldoglas
Copy link
Contributor

Sorry @isabelastisser , this is not a new feature, is just the migration issues.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 12, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'FlagComment' page to TypeScript [HOLD for payment 2024-02-19] [TS migration] Migrate 'FlagComment' page to TypeScript Feb 12, 2024
Copy link
Author

melvin-bot bot commented Feb 12, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 12, 2024
Copy link
Author

melvin-bot bot commented Feb 12, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-19. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Feb 12, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@ruben-rebelo] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 18, 2024
Copy link
Author

melvin-bot bot commented Feb 19, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@rushatgabhane
Copy link
Member

@danieldoglas could you please attach payment summary for review of #34734

@danieldoglas
Copy link
Contributor

Payment summary:

Contributor+: @rushatgabhane owed $250 via NewDot

@danieldoglas danieldoglas added the Bug Something is broken. Auto assigns a BugZero manager. label Feb 20, 2024
Copy link
Author

melvin-bot bot commented Feb 20, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@danieldoglas
Copy link
Contributor

Assigning bugzero for payment

@danieldoglas
Copy link
Contributor

Oh, actually this one is through new dot, so I don't think we need bugzero?

@sakluger
Copy link
Contributor

Yeah no need for me here! Your payment summary should do the trick. We're good to close the issue.

@JmillsExpensify
Copy link

$250 approved for @rushatgabhane based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 NewFeature Something to build that is a new item. Task Typescript Migration
Projects
Development

No branches or pull requests

6 participants