Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-14] [HOLD #24918][TS migration] Migrate 'IOU.js' lib to TypeScript #24926

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 22 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 NewFeature Something to build that is a new item. Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/actions/IOU.js 23
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@roryabraham
Copy link
Contributor

Excited for this one – I think it will be particularly valuable. When can we expect a PR?

@VickyStash
Copy link
Contributor

@roryabraham For now, this one is blocked by ReportUtils and Policy.js migrations. I'll prioritize it as soon as it gets unblocked!

@melvin-bot melvin-bot bot added the Overdue label Dec 4, 2023
@roryabraham
Copy link
Contributor

HOLDing for #24918

@melvin-bot melvin-bot bot removed the Overdue label Dec 4, 2023
@roryabraham roryabraham changed the title [TS migration] Migrate 'IOU.js' lib to TypeScript [HOLD][TS migration] Migrate 'IOU.js' lib to TypeScript Dec 4, 2023
@roryabraham roryabraham changed the title [HOLD][TS migration] Migrate 'IOU.js' lib to TypeScript [HOLD #24918][TS migration] Migrate 'IOU.js' lib to TypeScript Dec 4, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 5, 2024
@roryabraham
Copy link
Contributor

Still on HOLD

Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 6, 2024
Copy link
Author

melvin-bot bot commented Feb 7, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 7, 2024
Copy link
Author

melvin-bot bot commented Feb 7, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-14. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Feb 7, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@VickyStash] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 13, 2024
Copy link
Author

melvin-bot bot commented Feb 14, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@aimane-chnaif
Copy link
Contributor

Please assign me here

@garrettmknight
Copy link
Contributor

@aimane-chnaif offer out.

@aimane-chnaif
Copy link
Contributor

aimane-chnaif commented Feb 14, 2024

Thanks. I know this is exception but just wanted to discuss amount based on the scale of PR, though TS migration.
It was large with IOU.js which had almost 4k lines of code. (Also #34092 (review))
And as seen in Tests step of PR, it involved full regression test of money request flow.
So can the bounty be increased?
cc: @roryabraham

@garrettmknight garrettmknight removed their assignment Feb 14, 2024
@garrettmknight garrettmknight added the Bug Something is broken. Auto assigns a BugZero manager. label Feb 14, 2024
Copy link
Author

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@garrettmknight
Copy link
Contributor

Reassigning for payment. Should be a quick one once we decide!

@mallenexpensify
Copy link
Contributor

@roryabraham 👀 please on the above.

I'm brand new here as BZ so I don't want to jump in without much context.

@garrettmknight
Copy link
Contributor

Taking this one back over - @roryabraham can you comment on the complexity of this one?

@melvin-bot melvin-bot bot added the Overdue label Feb 23, 2024
@garrettmknight
Copy link
Contributor

@roryabraham mind chiming in?

@melvin-bot melvin-bot bot removed the Overdue label Feb 23, 2024
@roryabraham
Copy link
Contributor

Yeah, I think it's fair to bump this one up to $750 due to the high volume of testing that had to happen. Saying that because it's probably 3x a "standard" TS migration issue

@melvin-bot melvin-bot bot added the Overdue label Feb 26, 2024
@garrettmknight
Copy link
Contributor

Cool, all paid up. Closing!

Copy link
Author

melvin-bot bot commented Feb 27, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 NewFeature Something to build that is a new item. Task Typescript Migration
Projects
Development

No branches or pull requests

5 participants