Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-08-07 #24230

Closed
98 tasks done
OSBotify opened this issue Aug 7, 2023 · 27 comments
Closed
98 tasks done

Deploy Checklist: New Expensify 2023-08-07 #24230

OSBotify opened this issue Aug 7, 2023 · 27 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Aug 7, 2023

Release Version: 1.3.51-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Aug 7, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 7, 2023

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.51-0 🚀

@mvtglobally
Copy link

@Puneet-here Checking off the following PRs as they were deployed in the previous builds (for reference #24030)

#18507
#23046
#23272
#23321
#23447
#23527
#23621
#23636
#23648
#23650
#23705
#23748
#23760
#23774
#23779
#23781
#23802
#23828
#23880
#23911
#23919
#23931
#23934
#23937
#23938
#23947
#23965
#23971
#23972
#23976
#23977
#23990
#24023
#24035
#24036
#24037
#24052
#24060
#24091
#24097
#24109
#24152
#24203

@amyevans
Copy link
Contributor

amyevans commented Aug 8, 2023

Checked off #24130

@puneetlath
Copy link
Contributor

Checking off #24256 as it doesn't need to be treated as a deploy blocker as confirmed by @Beamanator here.

@puneetlath
Copy link
Contributor

Checking off #24234 as it's not a blocker as confirmed by @bondydaa here.

@puneetlath
Copy link
Contributor

Checking off #24266 as I don't think it's a blocker as explained here.

@puneetlath
Copy link
Contributor

Checking off #24239 as confirmed by @neil-marcellini here.

@puneetlath
Copy link
Contributor

Checking off #24284 as explained here.

@mvtglobally
Copy link

@puneetlath Regression sis at last 2%.

Current summary
#23516 (comment) checked off
#23822 is failing with #24241
#23825 pending validation on all platforms
#24029 is failing #23567, repro in prod
#24068 we are having issue testing older OS/versions. Can you check this internally?

@puneetlath
Copy link
Contributor

Checking off #24275 as the fix was CP'd and confirmed to be working here.

@mvtglobally
Copy link

Have 1 more potential blocker coming up.. Will post in a few

@puneetlath
Copy link
Contributor

Checking off #24267 as the fix was CP'd and confirmed to be working here.

@mvtglobally
Copy link

mvtglobally commented Aug 8, 2023

@puneetlath Regression is completed

Final update

@mvtglobally
Copy link

New potential blocker is #24300. check if its not a new functionality
cc: @aimane-chnaif since you pointed few similar non issues before as well

@mvtglobally
Copy link

checking off #23825

@puneetlath
Copy link
Contributor

Checking off #23822. I just tested on staging and it seems to work for me.

@puneetlath
Copy link
Contributor

puneetlath commented Aug 8, 2023

Checking off #24029 as I just tested and I am seeing the paste as plain text option on staging desktop.

@puneetlath
Copy link
Contributor

Checking off #24300 as I don't think it needs to block the deploy.

@aimane-chnaif
Copy link
Contributor

New potential blocker is #24300. check if its not a new functionality cc: @aimane-chnaif since you pointed few similar non issues before as well

Sorry for late. yes, it's dupe of #24296

@mvtglobally
Copy link

@puneetlath another potential blocker. but I feel it is the same root cause #24296 https://expensify.slack.com/archives/C049HHMV9SM/p1691553360267479

@Julesssss
Copy link
Contributor

Checking off #24068 as it should have been marked NO QA.

@Julesssss
Copy link
Contributor

Julesssss commented Aug 9, 2023

Thanks @mvtglobally, that issue is a follow-up issue from another PR so shouldn't be a blocker 👍

@Julesssss
Copy link
Contributor

@Julesssss
Copy link
Contributor

:shipit:

@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 9, 2023

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@OSBotify OSBotify reopened this Aug 9, 2023
@Julesssss
Copy link
Contributor

Julesssss commented Aug 9, 2023

Forgot to checkoff the deployer verifications checkboxes

@Julesssss
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

7 participants