[HOLD for payment 2023-08-17] [$1000] Web - Inconsistent display format for phone number contact in members page of workspace and room

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Precondition: Either logged in user should have primary account as phone number or logged user should have common workspace with user having primary account as phone number

1. Open the app
2. Open workspace room which has user with phone number as primary contact
3. Click on header to open details page
4. Click on members and observe the format of phone number contact displayed below display name of that user
5. Click on back and click on workspace name
6. Click on members and observe the format of phone number contact displayed below display name of that user, it is different then the one in step 4

Expected Result:

App should display phone number contact in newer format throughout the app on details pages

Actual Result:

App displays phone number contact in older format on room members page causing inconsistency in format between room members page and workspace members page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.45-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.3927.mp4

inconsistent.number.format.room.workspace.mp4

Expensify/Expensify Issue URL:
Issue reported by: GH handle - @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690377835176189

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01584c3a7472629000
• Upwork Job ID: 1687057935942258688
• Last Price Increase: 2023-08-03
• Automatic offers:
• fedirjh | Reviewer | 25991568
• samh-nl | Contributor | 25991575

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent display format for phone number contact in members page of workspace and room

What is the root cause of that problem?

On the workspace members page, the phone number is formatted using formatPhoneNumber provided by the withLocalize HOC.

App/src/pages/workspace/WorkspaceMembersPage.js

Lines 329 to 330 in f8bc305

	text: props.formatPhoneNumber(item.displayName),
	alternateText: props.formatPhoneNumber(item.login),

However, this is not the case for rooms (ReportParticipantsPage):

App/src/pages/ReportParticipantsPage.js

Line 63 in f8bc305

const userLogin = Str.removeSMSDomain(userPersonalDetail.login || '') || translate('common.hidden');

App/src/pages/ReportParticipantsPage.js

Line 78 in f8bc305

login: userLogin,

What changes do you think we should make in order to solve the problem?

We should consistently apply the formatPhoneNumber function for displaying phone numbers.

What alternative solutions did you explore? (Optional)

N/A

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Login text is different in members page in workspace and in room members page

What is the root cause of that problem?

We are using

const userLogin = Str.removeSMSDomain(userPersonalDetail.login || '') || translate('common.hidden');

in ReportParticipantsPage where as we need to use the standard LocalePhoneNumber.formatPhoneNumber to format the number.

What changes do you think we should make in order to solve the problem?

We should change the above line to

const userLogin = LocalePhoneNumber.formatPhoneNumber(userPersonalDetail.login || '') || translate('common.hidden');

and import

import * as LocalePhoneNumber from '../libs/LocalePhoneNumber';

in ReportParticipantsPage

What alternative solutions did you explore? (Optional)

[dylanexpensify]

reviewing today!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01584c3a7472629000

[melvin-bot]

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[dylanexpensify]

Woot! Looks like we got proposals! cc @fedirjh

[lekhaiphtech]

For above issue, we are by default showing alternate text that's why it's showing inconsistent display format for phone number, for fixing this issue we can change alternate text to "Text" or "Search Text"


[melvin-bot]

📣 @lekhaiphtech! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[lekhaiphtech]

Contributor Details
Expensify account email : lekha.iphtech@gmail.com
Upwork Profile Link : https://www.upwork.com/freelancers/~01d9a0b3b3f9156890

[fedirjh]

@samh-nl's proposal looks straightforward fix, let's proceed with it.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[tgolen]

🟢 for @samh-nl 👍

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @samh-nl 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[samh-nl]

PR is up for review: #24227

[melvin-bot]

🎯 ⚡️ Woah @fedirjh / @samh-nl, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @samh-nl got assigned: 2023-08-07 15:52:23 Z
• when the PR got merged: 2023-08-08 14:00:16 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: format phone number #24227

If no regressions arise, payment will be issued on 2023-08-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment offer (Reviewer)
• @samh-nl requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dylanexpensify]

Great work here!

[fedirjh]

BugZero Checklist:

• Link to the PR: feat: create formatPhoneNumber util function #16804
• Link to comment: feat: create formatPhoneNumber util function #16804 (comment)
• Link to discussion: This is not a regression, It's a missed case from a new feature implementation.
• Determine if we should create a regression test for this bug: I don't think we should require a regression test for this case, It's not truly a bug, but rather an inconsistency.

[dylanexpensify]

Payment summary:

• Reporter: @dhanashree-sawant $250
• Contributor: @samh-nl $1,500
• C+: @fedirjh $1,500

Upwork job. Please apply!

[dhanashree-sawant]

Hi @dylanexpensify, If possible, can you send me invite to the job?

[dylanexpensify]

Payments sent @fedirjh and @samh-nl! @dhanashree-sawant invite to job sent!

[dylanexpensify]

Offer waiting to be accepted @dhanashree-sawant!

[dhanashree-sawant]

Thanks @dylanexpensify, I have accepted the offer.

[dylanexpensify]

Paying out!

[dylanexpensify]

all done!