[$1000] Web - Clicking on Avatar in Header of Task Detail page takes to wrong user details #23579

kbecciv · 2023-07-25T19:00:38Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Create a task with assignee
Go to task page
Wait till the time in the bottom shows up
Click on User in Header of Task details page

Expected Result:

There are two possibilities:
It should show the details of the task creator

Actual Result:

Wrong user in Header and User Details page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.45.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-21.at.2.00.52.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @BhuvaneshPatil
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689928645869329

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ccc9b0b61fc1bf49
Upwork Job ID: 1684047964217954304
Last Price Increase: 2023-07-26

melvin-bot · 2023-07-25T19:00:43Z

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-07-25T19:00:45Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

kbecciv · 2023-07-25T19:01:32Z

Proposal by: @BhuvaneshPatil
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689928645869329

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking on header of task report opens assignee page instead of members/details page

What is the root cause of that problem?

When we click on header - navigateToDetailsPage function is called.

App/src/pages/home/HeaderView.js

Lines 164 to 170 in b7d17e0

    
           <PressableWithoutFeedback 
        
               onPress={() => ReportUtils.navigateToDetailsPage(props.report)} 
        
               style={[styles.flexRow, styles.alignItemsCenter, styles.flex1]} 
        
               disabled={isTaskReport && !ReportUtils.isOpenTaskReport(props.report)} 
        
               accessibilityLabel={title} 
        
               accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON} 
        
           >

And this function -

App/src/libs/ReportUtils.js

Lines 1269 to 1281 in b7d17e0

    
           function navigateToDetailsPage(report) { 
        
               const participantAccountIDs = lodashGet(report, 'participantAccountIDs', []); 
        
               if (isChatRoom(report) || isPolicyExpenseChat(report) || isChatThread(report)) { 
        
                   Navigation.navigate(ROUTES.getReportDetailsRoute(report.reportID)); 
        
                   return; 
        
               } 
        
               if (participantAccountIDs.length === 1) { 
        
                   Navigation.navigate(ROUTES.getProfileRoute(participantAccountIDs[0])); 
        
                   return; 
        
               } 
        
               Navigation.navigate(ROUTES.getReportParticipantsRoute(report.reportID)); 
        
           }

For task which has assignee, there is only one accountID in participantAccountIDs (which is task assignee), that's why we are opening the assignee profile page.

What changes do you think we should make in order to solve the problem?

The solution depends on what page do we want to open

If we want to open details page
Then we shall add the condition here -

if (isChatRoom(report) || isPolicyExpenseChat(report) || isChatThread(report) || isTaskReport(report)) {
Navigation.navigate(ROUTES.getReportDetailsRoute(report.reportID));
return;
}
If we want to open the members page -
Then there are two approaches for this -
- Add the following condition that check if current report is task report or not and based on that navigates to required page
  
  if(isTaskReport(report)){
  Navigation.navigate(ROUTES.getReportParticipantsRoute(report.reportID));
  return;
  }
- Add condition while we are redirecting to user details page to check if the report is task report or not
  
  if (participantAccountIDs.length === 1 && !isTaskReport(report)) {
  Navigation.navigate(ROUTES.getProfileRoute(participantAccountIDs[0]));
  return;
  }

What alternative solutions did you explore? (Optional)

BhuvaneshPatil · 2023-07-25T19:08:25Z

Expanding on - #23579 (comment)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Clicking on Avatar in Header of Task Detail page takes to wrong user details

What is the root cause of that problem?

When we click on header - navigateToDetailsPage function is called. And in case of task that is assigned to someone.
participantAccountIDs has only one id. and we are take to profile details of task assignee profile details page.

What changes do you think we should make in order to solve the problem?

as mentioned by @thienlnam here - https://expensify.slack.com/archives/C049HHMV9SM/p1690311552613889?thread_ts=1689928645.869329&cid=C049HHMV9SM

Clicking on task header should take us to profile details of creator. To adjust for this behaviour -
we can modify this method(navigateToDetailsPage) as following -

We add the check if current report is task or not. and based on that redirect user to creator's profile page.
We can get the creatorID using ownerAccountID field.

    if(isTaskReport(report)){
        Navigation.navigate(ROUTES.getProfileRoute(report.ownerAccountID));
        return;
    }

What alternative solutions did you explore? (Optional)

JmillsExpensify · 2023-07-26T03:48:08Z

Able to reproduce this one. Given that the task creator is the avatar that appears in the header, I think that's the one we should be showing.

melvin-bot · 2023-07-26T03:48:19Z

Job added to Upwork: https://www.upwork.com/jobs/~01ccc9b0b61fc1bf49

melvin-bot · 2023-07-26T03:48:22Z

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-07-26T03:48:28Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

Nodebrute · 2023-07-26T04:12:48Z

dupe of #23296 and #22498. @jasperhuangg will be taking care of this #23296 (comment).

JmillsExpensify · 2023-07-26T04:16:04Z

I think that second one is a closer replica. Thanks for flagging. I'll close though Jasper, please re-open if you disagree.

JmillsExpensify · 2023-07-26T04:16:41Z

Further for clarity, since this is a duplicate report, no payout is issued for reporting.

BhuvaneshPatil · 2023-07-26T04:28:25Z

@Nodebrute. I have mentioned the root cause for #23296 in slack conversation. So they are not dupes.

The PR that was going to fix -#22498, has been merged and it's still reproducible.

Nodebrute · 2023-07-26T04:33:22Z

@BhuvaneshPatil the issue related to task header has been reported multiple times and this bug was caught during the PR of that issue. where they decided to hold it #22586 (comment).

BhuvaneshPatil · 2023-08-07T18:02:43Z

Updated proposal -

Dupe of this issue that was reported after this issue, proposal on that issue - #24144 (comment)

Proposal

Please re-state the problem that we are trying to solve in this issue.

It must show the detail of the user's profile that assigns the task

What is the root cause of that problem?

As decided here in slack - https://expensify.slack.com/archives/C01GTK53T8Q/p1691426870537099?thread_ts=1691334974.136469&cid=C01GTK53T8Q

We should show the task title (the one that appears in header below the avatar, and avatar will be of task creator)

What changes do you think we should make in order to solve the problem?

We are disabling showing shouldUseFullTitle here -

App/src/pages/ReportDetailsPage.js

Lines 153 to 160 in 09f6b6b

    
           <DisplayNames 
        
               fullTitle={ReportUtils.getReportName(props.report)} 
        
               displayNamesWithTooltips={displayNamesWithTooltips} 
        
               tooltipEnabled 
        
               numberOfLines={isChatRoom ? 0 : 1} 
        
               textStyles={[styles.textHeadline, styles.textAlignCenter, isChatRoom ? undefined : styles.pre]} 
        
               shouldUseFullTitle={shouldUseFullTitle} 
        
           />

For that value we use -

App/src/pages/ReportDetailsPage.js

Lines 63 to 64 in 09f6b6b

    
           const shouldDisableSettings = useMemo(() => ReportUtils.shouldDisableSettings(props.report), [props.report]); 
        
           const shouldUseFullTitle = !shouldDisableSettings;

We shall change - shouldUseFullTitle to something like below -

const shouldUseFullTitle = !shouldDisableSettings || ReportUtils.isTaskReport(props.report);

It will allow to show full title in case we are opening a task report.

If we want to show the settings option as well -
we can change shouldDisableSettings in ReportUtils -

function shouldDisableSettings(report) {
    return !isPolicyExpenseChat(report) && !isChatRoom(report) && !isChatThread(report) && !isTaskReport(report);
}

What alternative solutions did you explore? (Optional)

kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 25, 2023

melvin-bot bot assigned JmillsExpensify Jul 25, 2023

JmillsExpensify added the External Added to denote the issue can be worked on by a contributor label Jul 26, 2023

melvin-bot bot changed the title ~~Web - Clicking on Avatar in Header of Task Detail page takes to wrong user details~~ [$1000] Web - Clicking on Avatar in Header of Task Detail page takes to wrong user details Jul 26, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 26, 2023

melvin-bot bot assigned 0xmiros Jul 26, 2023

JmillsExpensify closed this as completed Jul 26, 2023

BhuvaneshPatil mentioned this issue Aug 6, 2023

[HOLD for payment 2023-08-24] [$1000] It must show the detail of the user's profile that assigns the task #24144

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$1000] Web - Clicking on Avatar in Header of Task Detail page takes to wrong user details #23579

[$1000] Web - Clicking on Avatar in Header of Task Detail page takes to wrong user details #23579

kbecciv commented Jul 25, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jul 25, 2023

melvin-bot bot commented Jul 25, 2023

kbecciv commented Jul 25, 2023

BhuvaneshPatil commented Jul 25, 2023 •

edited

Loading

JmillsExpensify commented Jul 26, 2023

melvin-bot bot commented Jul 26, 2023

melvin-bot bot commented Jul 26, 2023

melvin-bot bot commented Jul 26, 2023

Nodebrute commented Jul 26, 2023 •

edited

Loading

JmillsExpensify commented Jul 26, 2023

JmillsExpensify commented Jul 26, 2023

BhuvaneshPatil commented Jul 26, 2023 •

edited

Loading

Nodebrute commented Jul 26, 2023 •

edited

Loading

BhuvaneshPatil commented Aug 7, 2023 •

edited

Loading

[$1000] Web - Clicking on Avatar in Header of Task Detail page takes to wrong user details #23579

[$1000] Web - Clicking on Avatar in Header of Task Detail page takes to wrong user details #23579

Comments

kbecciv commented Jul 25, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jul 25, 2023

melvin-bot bot commented Jul 25, 2023

Bug0 Triage Checklist (Main S/O)

kbecciv commented Jul 25, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

BhuvaneshPatil commented Jul 25, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

JmillsExpensify commented Jul 26, 2023

melvin-bot bot commented Jul 26, 2023

melvin-bot bot commented Jul 26, 2023

melvin-bot bot commented Jul 26, 2023

Nodebrute commented Jul 26, 2023 • edited Loading

JmillsExpensify commented Jul 26, 2023

JmillsExpensify commented Jul 26, 2023

BhuvaneshPatil commented Jul 26, 2023 • edited Loading

Nodebrute commented Jul 26, 2023 • edited Loading

BhuvaneshPatil commented Aug 7, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

kbecciv commented Jul 25, 2023 •

edited by melvin-bot bot

Loading

BhuvaneshPatil commented Jul 25, 2023 •

edited

Loading

Nodebrute commented Jul 26, 2023 •

edited

Loading

BhuvaneshPatil commented Jul 26, 2023 •

edited

Loading

Nodebrute commented Jul 26, 2023 •

edited

Loading

BhuvaneshPatil commented Aug 7, 2023 •

edited

Loading