[HOLD for payment 2023-09-07] [$1000] PDF preview shows blank white area

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat
2. Send attached PDF attached in this OP

Expected Result:

PDF preview should be shown properly

Actual Result:

PDF preview shows blank white area

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.42-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1689772946.mp4

GITK0823.1.MP4

International_Money_Transfer__Send_Money_Abroad_with_Wise__ex-TransferWise_.pdf

Expensify/Expensify Issue URL:
Issue reported by: @DinalJivani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689772959912119

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01371d83289588168c
• Upwork Job ID: 1683599874921218048
• Last Price Increase: 2023-08-21
• Automatic offers:
• ShogunFire | Contributor | 26292349

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[JmillsExpensify]

Jumping in to test this now.

[JmillsExpensify]

I'm able to reproduce this one, so I'll triage it. Note: The white space is only visible in the preview, and I wasn't able to reproduce the same issue on native iOS.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01371d83289588168c

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[alexcherut]

I don't know what you are using for rendering, but the sample file has a page of 414 x 12454 points.
The page height is equal to 173 inch or 4.4 meters.
Pages that big will likely overflow all the buffers. perhaps, "won't fix" is the most appropriate resolution.

[melvin-bot]

📣 @alexcherut! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[alexcherut]

Contributor details
Your Expensify account email: alex@coscript.biz
Upwork Profile Link: https://www.upwork.com/freelancers/~01b1743757f2e29b3d

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[melvin-bot]

@JmillsExpensify, @eVoloshchak Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[eVoloshchak]

Pages that big will likely overflow all the buffers. perhaps, "won't fix" is the most appropriate resolution.

@alexcherut, but it's displayed correctly in preview and in other apps, there definately is a way to render this properly

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[JmillsExpensify]

Let's close if not reproducible again.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Calculating the devicePixelRatio for the pdf to display with less pixels than the limit of the platform #25721

If no regressions arise, payment will be issued on 2023-09-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @eVoloshchak does not require payment (Eligible for Manual Requests)
• @ShogunFire requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: Not applicable, this is an issue with Safari mobile itself
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this is an edge case that is present only for extremely large PDF files, I don't think an additional discussion is needed
• Determine if we should create a regression test for this bug.
  Is it easy to test for this bug? Yes
  Is the bug related to an important user flow? Yes
  Is it an impactful bug? No
  While the bug isn't preventing users from using the app, this is a user-facing and commonly used flow, so I think a small regression test is needed here. In addition to that, the PDF limits that were causing the bug can and will change with new devices/OS/Browser versions, so it's important we test this periodically

[eVoloshchak]

Regression Test Proposal

1. Open any chat
2. Click "+" -> "Add attachment"
3. Select this PDF file
4. Verify that PDF preview isn't blank

Do we agree 👍 or 👎

[DinalJivani]

@eVoloshchak Just here to mention I didn't received Upwork job offer automatically!

bump ^^ @eVoloshchak @JmillsExpensify

[ShogunFire]

@JmillsExpensify Can you make the paiement thanks

[DinalJivani]

I didn't received Upwork job offer automatically!

@JmillsExpensify Can you please check if possible

[JmillsExpensify]

Agree with the regression test. I'll get that added. In the meantime, here's the payment summary:

• Issue reporter: @DinalJivani $250 (created before Sept 1)
• Contributor: @ShogunFire $1,000
• Contributor: @eVoloshchak $1,000

@ShogunFire I see you have a thumbs down on the automated message that the urgency bonus doesn't apply. If you disagree, please explain why.

[JmillsExpensify]

Upwork job is here: https://www.upwork.com/jobs/~01371d83289588168c. Please apply if not automatically assigned.

[ShogunFire]

@JmillsExpensify Ahah sorry I don't disagree, I was just not happy about it

[DinalJivani]

@JmillsExpensify
applied on Upwork job.

[JmillsExpensify]

Ok thanks all!

@DinalJivani Just sent an offer.

@ShogunFire Just issued payment.

@eVoloshchak I believe you'll create a payment request separately.

[JmillsExpensify]

Everyone paid in Upwork is processed. Keeping open for the regression test and @eVoloshchak's payment.

[pecanoro]

Not overdue!

[pecanoro]

@eVoloshchak Don't forget to finish the regression so we can finish the payment and close this

[eVoloshchak]

Huh, I thought I already requested the payment for this, but can't find it, looks like I didn't
Requested the payment right now, please double-check it isn't a duplicate

@pecanoro, the regression test proposal is here

[pecanoro]

@JmillsExpensify All ready for you to finish any payments left and close it!

[JmillsExpensify]

Regression test is created and confirmed that there is a NewDot payment. Closing.

[JmillsExpensify]

$1,000 payment approved for @eVoloshchak based on BZ summary.