[Awaiting checklist completion] [$1000] Composer top padding collapsed in room after scroll up

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to a room
2. add some chats until we can scroll up the screen
3. Scroll to the bottom and scroll upp

Expected Result:

There should be some padding at the top of the composer

Actual Result:

No padding at the top of the composer, it will be notes when hovering over the message which is closer to compose box

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.37-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.27.mp4

Expensify/Expensify Issue URL:
Issue reported by: @wildan-m
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688604509171109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016810fbd90ab7373e
• Upwork Job ID: 1677363585491148800
2023-07-21
• Automatic offers:
• situchan | Contributor | 25763008
• mkarkachov | Contributor | 25865850

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jeet-dhandha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Composer top padding is not visible.

What is the root cause of that problem?

• The root cause is that the Participant's Local Time is not visible when in the room thread. But is visible when in Chat thread. Thus showing inconsistency in padding over the composer.

Chat Thread

Room Thread

What changes do you think we should make in order to solve the problem?

• Solution 1: Add a top padding to the composer by default.
• Solution 2: Render a different component similar to the Participant's Local Time.

What alternative solutions did you explore? (Optional)

• N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016810fbd90ab7373e

[melvin-bot]

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[sarious]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Composer top padding collapsed in room after scroll up.

What is the root cause of that problem?

The root cause of the problem is that there is paddings for scrollable container (chat content). When the user scrolls up the paddings is invisible.

Invisible paddings of chat content

What changes do you think we should make in order to solve the problem?

So to solve this issue we can get rid of bottom padding of chat content and add top padding to View with action buttons and Input.

1. We need to get rid of bottom padding of chat content. See screenshot below:

Bottom padding before changes

Bottom padding before changes (when scrolling)

To achieve this we need replace paddingVertical: 16 with paddingBottom: 16 in chatContentScrollView in styles.js file.
NOTE! You may notice that we remove top padding from style and leave bottom padding, but need to remove bottom padding. This is because parent component has transform: scaleY(-1); style:

transform: scaleY(-1) style of parent

2.

After that we need to add 16px top padding to ReportActionCompose container:

Container layout before changes

But we need to add padding only in case if we don't need to show Participant Local Time. So for that we need to change style of the top View in ReportActionCompose component:
!(shouldShowReportRecipientLocalTime && hasReportRecipient) && styles.pt4,

pt4 is style for adding paddingTop: 16

3.

Also we need to add paddingTop: 16 to container with ArchivedReportFooter to fix the problem when composer is hidden. We can do it by adding styles.pt4 to wrapper View in ReportFooter.js:

Container layout after changes

The result in Room without Participant Local Time

The result in Chat with Participant Local Time

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

📣 @sarious! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[sarious]

Contributor details
Your Expensify account email: sarious.w@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~012449b41f0680e59b

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[uafrontender]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Margin top is missed at the top of ReportActionCompose component

What is the root cause of that problem?

If it's multi-user chatroom or concierge room ReportRecipientLocalTime is not appeared and in this case top margin should be added

What changes do you think we should make in order to solve the problem?

App/src/pages/home/report/ReportActionCompose.js

Line 960 in 2ec3067

hasExceededMaxCommentLength && styles.borderColorDanger,

after this line we should add top margin (padding will be displayed incorrect) with

!shouldShowReportRecipientLocalTime && styles.mt4

App/src/pages/home/report/ReportActionsList.js

Line 159 in 2ec3067

contentContainerStyle={[styles.chatContentScrollView, shouldShowReportRecipientLocalTime && styles.pt0]}

here to remove bottom padding in scroll area, we should remove this code

shouldShowReportRecipientLocalTime && styles.pt0

and in styles.js replace this code

App/src/styles/styles.js

Line 1468 in 2ec3067

paddingVertical: 16,

with paddingBottom: 16,

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@twisterdotcom, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[twisterdotcom]

How are these proposals looking @0xmiroslav?

[ghost]

Can post proposal @twisterdotcom ?

[twisterdotcom]

You can!

[ghost]

Sure Ted! Thanks!

[jeet-dhandha]

Any thoughts on my proposal #22389 (comment) ?

[nebiyuelias1]

paddingTop: shouldShowReportRecipientLocalTime && hasReportRecipient ? 0 : 16

But did you check out the style guide? It says inline styles are not allowed: https://github.com/Expensify/App/blob/main/contributingGuides/STYLING.md#inline-styles

[melvin-bot]

📣 @nebiyuelias1! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Composer top padding collapsed in room after scroll up #23992

If no regressions arise, payment will be issued on 2023-08-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mkarkachov requires payment offer (Contributor)
• @situchan requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[twisterdotcom]

Payment summary:

@mkarkachov paid $1500 here: https://www.upwork.com/nx/wm/offer/25865850 (Contributor)
@mkhutornyi will be paid $150 here: https://www.upwork.com/nx/wm/offer/26194971
@situchan paid $1500 here: https://www.upwork.com/nx/wm/offer/25763008) (Contributor+)
@wildan-m never applied: #22389 (comment). Due $250 if they do.

@situchan please complete the checklist.

[mkhutornyi]

@twisterdotcom we worked together on PR based on #22389 (comment). And actually my proposal was completely used to fix any regressions.

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal:
There are many test cases to consider as stated in PR description
So in summary, this can be simplified test step:

1. Go to any chat room with enough messages history
2. While scrolling messages, verify that there's always some padding above composer

[wildan-m]

@twisterdotcom I thought Melvin stored my UW account. Just applied

[twisterdotcom]

Ahh yes. @mkhutornyi could you apply for the job as well? Upwork job

[mkhutornyi]

@twisterdotcom applied, thanks

[twisterdotcom]

@wildan-m you've been paid.
@mkarkachov please accept the offer here: https://www.upwork.com/nx/wm/offer/26194971

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[twisterdotcom]

@CortneyOfstad I'm out for Parental Leave. Please:

1. Ask @situchan to complete the checklist.
2. Pay @mkarkachov $1000 + $500 bonus here: https://www.upwork.com/nx/wm/offer/26194971

[mkhutornyi]

@twisterdotcom accepted offer

[CortneyOfstad]

@situchan We need you to complete the check list here and link the appropriate details. Thank you!

[situchan]

@situchan We need you to complete the check list here and link the appropriate details. Thank you!

Here: #22389 (comment)

[CortneyOfstad]

Sorry for the confusion! We ask that you work in the original checklist, otherwise the GH cannot be closed. Thank you!

[CortneyOfstad]

Did some digging and it shows that @mkarkachov was already paid, but @mkhutornyi was still awaiting payment. That has been issued, so this can be closed. Thanks all!