[$1000] [HOLD FOR PAYMENT 13-07-23] Web - Repeated copy of contact method URL adds characters in URL triggering its not here page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings
3. Open profile
4. Open contact method
5. Open non default contact method and copy the URL
6. paste URL in any report and send
7. Click on URL and observe that it opens correct contact method page, again copy the URL and send in report
8. Click on URL sent in step 7 to observe that now it provides 'Hmm its not here' page

Expected Result:

App should not add content to URL while visiting to avoid 'Hmm its not here' page error on recopy and revisit

Actual Result:

App adds new content in URL of contact method whenever we visit it again by deep link triggering 'Hmm its not here' on 2nd URL copy and visit

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.36-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

recopy.and.revisit.contact.method.not.here.error.mp4

Recording.3426.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688490569899239

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ae16ee8b22ed14a7
• Upwork Job ID: 1680122209842212864
• Last Price Increase: 2023-07-15

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Repeated copy of contact method URL adds characters in URL triggering its not here page

What is the root cause of that problem?

If we take a look at the link, we can see the email param was decoded 2 times which caused the issue.

What changes do you think we should make in order to solve the problem?

We should get rid of using encodeURIComponent in here, it should be:

getEditContactMethodRoute: (contactMethod) => `${SETTINGS_CONTACT_METHODS}/${contactMethod}/details`,

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Julesssss]

Already fixed here

[Julesssss]

Resolved as of v1.3.37-3

[Julesssss]

Reporter bonus is valid though. So I'll leave the issue open.

[situchan]

@Julesssss can you please assign me to the issue? As I was the author of PR

[Julesssss]

Ah wait. I don't think that's right. @dhanashree-sawant raised the bug first and because the issue was a dupe it's not valid for payment for both issues.

BUT, we can use this issue for payment. As it was the original.

• Reporter bonus: @dhanashree-sawant
• bounty: @situchan
• C+ review: @thesahindia

[situchan]

Right, I am not eligible for reporting bonus but may be 50% speed bonus.

[situchan]

Also I think @thesahindia should be compensated here for C+ review.

[NicMendonca]

Sorry! I don't know why this didn't pop to a daily.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ae16ee8b22ed14a7

[melvin-bot]

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[NicMendonca]

Can everyone please apply to the job? https://www.upwork.com/jobs/~01ae16ee8b22ed14a7

[melvin-bot]

📣 @thesahindia Please request via NewDot manual requests for the Contributor role ($1000)

[melvin-bot]

📣 @dhanashree! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

The BZ member will need to manually hire dhanashree for the Reporter role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

[NicMendonca]

@situchan @dhanashree-sawant - can you please accept the offer so we can issue payment?

[NicMendonca]

@situchan @dhanashree-sawant - you've both been paid 🎉

@thesahindia do you want me to keep this open as a reminder to request payment in NewDot?

[NicMendonca]

@thesahindia says he's got this on his to-do! closing!

[JmillsExpensify]

@NicMendonca Do you mind adding a payment summary on this issue so that I can pay @thesahindia?

[NicMendonca]

• reporter: @dhanashree-sawant - $250
• Contributor: @situchan - $1,500
• C+: @thesahindia - $1,500

cc @JmillsExpensify ^^

[thesahindia]

Looks like I requested $1500. Editing it now!

[situchan]

$1500 should be correct amount. PR was merged within a day

[thesahindia]

Ahh, thanks @situchan. Changing it again.

[NicMendonca]

Sorry, you're right! This was quite a long time ago I forgot!

[NicMendonca]

reporter: @dhanashree-sawant - $250
Contributor: @situchan - $1,500
C+: @thesahindia - $1,500

[JmillsExpensify]

$1,500 payment approved for @thesahindia based on BZ summary.