[HOLD for payment 2023-07-14] [HOLD for payment 2023-07-12] Already selected members disappears after you search for new members

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. On staging web chrome > Create a new workspace > Invite members
2. Click on Invite
3. Now on search bar, type the email of a new user and select it
4. Now immediately, remove the previous user email and now try to search with the email of a different user and select it and notice that the old user that you selected on step 3 gets disappeared. Now if you click on invite, only the last user gets selected
5. If followed the same on production, the old selected users never disappears

Expected Result:

The old selected members should not disappear after you search for new members

Actual Result:

The old selected members disapperas after you search for new members

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.36-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-07-03_20.30.25.mp4

Recording.1133.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688395631136579

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012b0dacfaa4c2503c
• Upwork Job ID: 1679184518209077248
• Last Price Increase: 2023-07-12

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[flodnv]

@s-alves10 can you please check this? #21700 (review)

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[raphaelppp]

(rescinded, the bug reproduction is timing-sensitive)

[s-alves10]

@flodnv

This issue is because the new user wasn't added here

App/src/pages/workspace/WorkspaceInvitePage.js

Lines 181 to 186 in 4d3c4ef

	_.forEach(this.state.selectedOptions, (option) => {
	if (!_.has(detailsMap, option.login)) {
	return;
	}
	selectedOptions.push(detailsMap[option.login]);
	});

Will be fixed by below code

        _.forEach(this.state.selectedOptions, (option) => {
            if (_.has(detailsMap, option.login)) {
                selectedOptions.push(detailsMap[option.login]);
            } else {
                selectedOptions.push(option);
            }
        });

[Julesssss]

PR is in review here

[rushatgabhane]

raised a manual request on new dot https://staging.new.expensify.com/r/701637755905470

[Julesssss]

PR merged, removing the label

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012b0dacfaa4c2503c

[melvin-bot]

Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new.

[Christinadobrzyn]

Adding Internal label for Upwork job to be created.

Hired @rushatgabhane in Upwork
Internal job- https://www.upwork.com/ab/applicants/1679184518209077248/job-details
External job- https://www.upwork.com/jobs/~012b0dacfaa4c2503c

I think that's all to be hired for this, yeah?

[Christinadobrzyn]

• Ready for payment @rushatgabhane do you want to be paid through NewExpensify?
• Is there a regression test needed for this?

[Christinadobrzyn]

I'm going to be ooo until July 31st so going to unassign and assign a new teammate.

@mallenexpensify At this time, we're just waiting on a response to #22123 (comment)

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mallenexpensify]

@rushatgabhane is paid outside of Upwork.
@avi-shek-jha, can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~012b0dacfaa4c2503c

[avi-shek-jha]

@rushatgabhane is paid outside of Upwork. @avi-shek-jha, can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~012b0dacfaa4c2503c

@mallenexpensify I have applied. Thank You.

[mallenexpensify]

Thanks @avi-shek-jha , I've hired you.

[mallenexpensify]

@avi-shek-jha paid!
@rushatgabhane can you please fill out the checklist above?
#22123 (comment)

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: Update selectedOptions when personalDetails or policyMembers changes #21700

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Update selectedOptions when personalDetails or policyMembers changes #21700 (comment)

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This is part of checklist. We didn't test it properly i guess

4. Determine if we should create a regression test for this bug. No. It would have been caught easily by QA in staging

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - No

[rushatgabhane]

This has been paid on new dot https://staging.new.expensify.com/r/701637755905470

And checklist is complete. This issue can be closed.