[HOLD for payment 2023-08-03] [$1000] IOS - The title field is cleared when the Confirm task button is pressed

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to New Expensify on an iOS handset
2. Click on + icon
3. Click on assign task
4. Enter title and click on next
5. Enter an assignee
6. Click on Confirm task

Expected Result:

The title field should not be cleared

Actual Result:

The title field is cleared

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.34-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

title-cleared.1.MP4

ios.ass.task.0107.mp4

Expensify/Expensify Issue URL:
Issue reported by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688216349574539

[View all open jobs on GitHub](https://github.com/Expensify/App/issues?q=is%3Aopen+is% 3Aissue+label%3A%22Help+Wanted%22)

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f1a312f3e2545b22
• Upwork Job ID: 1676161673601695744
• Last Price Increase: 2023-07-11

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[aman-atg]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The title field is cleared when the Confirm task button is pressed

What is the root cause of that problem?

The root cause of the problem is the usage of clearOutTaskInfo here which makes the props.task empty for a few secs.

What changes do you think we should make in order to solve the problem?

We can just remove this line of code which will fix the issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f1a312f3e2545b22

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[alitoshmatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOS - The title field is cleared when the Confirm task button is pressed

What is the root cause of that problem?

Before dismissing modal clearOutTaskInfo() is called, and dismissing modal is not happening instantly, that's why we can see result of clearOutTaskInfo function

What changes do you think we should make in order to solve the problem?

We can call clearOutTaskInfo when new task component unmounts, this way we make sure that task gets cleared out only when component is removed. We remove clearOutTaskInfo from createTaskAndNavigate function

App/src/pages/tasks/NewTaskPage.js

Line 69 in 754723d

function NewTaskPage(props) {

Like this

    useEffect(() => clearOutTaskInfo, []);

What alternative solutions did you explore? (Optional)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The title field is cleared

What is the root cause of that problem?

We're clearing the task info here after confirming. The screen transition takes some time so we can see the values are cleared.

What changes do you think we should make in order to solve the problem?

We should run the clearOutTaskInfo inside InteractionManager.runAfterInteractions so it only clears the value after the screen transition completes.

What alternative solutions did you explore? (Optional)

Both Title and Description will be benefit from the same fix as well.

Another approach is to:

• Remove the clearOutTaskInfo in here
• define a new ref shouldClearOutTaskInfoOnUnmount in the NewTaskPage

const shouldClearOutTaskInfoOnUnmount = React.useRef(false);

• set it to true when confirming
• on component unmount, check if shouldClearOutTaskInfoOnUnmount.current is true, if yes, clear the task values

useEffect(() => {
        return () => {
            if (shouldClearOutTaskInfoOnUnmount.current) {
                TaskUtils.clearOutTaskInfo();
            }
        }
    }, []);

If we don't use the ref, the task values will be cleared also when going back to previous page, which is not desirable.

[laurenreidexpensify]

@0xmiroslav what do you think about these two proposals ^^

[laurenreidexpensify]

@0xmiroslav bump on proposal review, thanks

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[laurenreidexpensify]

Messaged @0xmiroslav in Slack :)

[0xmiros]

@dukenv0307's alternative solution looks good to me.
@dukenv0307 can you please find out all occurrences where similar issue happens?
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @robertjchen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@robertjchen @laurenreidexpensify @0xmiroslav this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[robertjchen]

Awaiting updated proposal w/ all occurrences where the similar issue happens per: #22078 (comment)

[aman-atg]

Bug reporter payment has already been handled in #23294

@laurenreidexpensify I think the original reporter should have been paid here as I reported the issue earlier.

[robertjchen]

Thanks for organizing all the details, we'll review this! 👀

[robertjchen]

Still getting around to evaluating this, thanks for everyone's patience! 🙏

[dukenv0307]

@robertjchen Bump

[laurenreidexpensify]

@robertjchen have you had a chance to review this? thanks

[dukenv0307]

@robertjchen Any update here?

[robertjchen]

Appreciate your patience, circling back to this and will respond before end of day.

[robertjchen]

Okay, my analysis on the situation is:

• This bug report here in came in earlier than the one in [$1000] Web -Task - Empty description is displayed even when description is set in task #23294 , but we did not catch the duplicate report and paid the original reporter in the other issue. That is unfortunate, but is also on us, so we should pay the reporter here:

  • $250 to @aman-atg

• The original PR: fix: The title field is cleared when the Confirm task button is pressed #22983 was merged within 3 business days and didn't cause a regression (though it was mistakenly reverted under incorrect assumptions) so that's:

  • $1000 + $500 bonus to @dukenv0307
  • $1000 + $500 bonus to C+ reviewer @0xmiroslav

• For the fix Fix: The title field is cleared when the Confirm task button is pressed #23342 My view here is that the PR is basically a re-instatement of the original reverted changes with related causes. However, I still think a discretionary bounty should still be paid out here given the efforts and mixup:

  • [HOLD for payment 2023-08-15] App crashes when edited description of task #23210 no additional payment per the comment here
  • [$1000] Web -Task - Empty description is displayed even when description is set in task #23294 this comment points out the overlap.
    • $1000 discretionary bonus to @dukenv0307
    • $1000 discretionary bonus to @situchan

cc: @laurenreidexpensify for final confirmation and next steps! 👍

[situchan]

@robertjchen what about me for reviewing 2nd PR? I took over based on #22078 (comment)

[robertjchen]

@situchan Updated my comment! 👍

[robertjchen]

@laurenreidexpensify let me know if you have any questions!

[laurenreidexpensify]

Payment Summary:

• $250 - Bug Report @aman-atg - payment issued in Upwork (original job post)
• $1500 - Contributor - @dukenv0307 - payment issued in Upwork for job (original job post)
• $1500 - C+ review, offer sent to @0xmiroslav in Upwork (new job post)
• $1000 - discretionary bonus, offer sent to @dukenv0307 in Upwork (new job post)
• $1000 - discretionary bonus, offer sent to @situchan in Upwork (new job post)

@0xmiroslav can you confirm the regression checklist steps?

[0xmiros]

@laurenreidexpensify can you please send offer to https://www.upwork.com/freelancers/~01cf406998cdcfc7ae?
Discussion: https://expensify.slack.com/archives/C01SKUP7QR0/p1692226249296529?thread_ts=1691559426.466079&cid=C01SKUP7QR0

[0xmiros]

No PR caused regression. Original issue was minor UI bug, though root cause was a bit critical.
I propose regression test for #23294 instead of this GH as they have similar root cause.

Regression Test Proposal

1. In any task report with description set, click on + and click Assign task
2. Write any title, keep description empty and click next
3. Close Confirm task modal
4. Click on task description on current task report
5. Verify that description input is prefilled correctly

[laurenreidexpensify]

@0xmiroslav offer sent 👍

[laurenreidexpensify]

Payments have all been issued, closing.