[HOLD for payment 2023-07-24] [$1000] Web - Tooltip is not shown for a new user on invite message page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot on web chrome
2. Create a new workspace > Invite members > Click on invite > Select two members (For the First member, enter an email of a NEW user and the second user should be an old user)
3. Click on Next and hover over the profile avatars. Notice for the old user tooltip is shown, but if you hover over the avatar for the new user, tooltip is not shown.

Expected Result:

Tooltip should be shown for a new user on invite message page

Actual Result:

Tooltip is not shown for a new user on invite message page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.34-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

green-2023-06-29_12.36.12.mp4

Recording.3326.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688021163521579

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aa1190833be5a152
• Upwork Job ID: 1677083442629509120
• Last Price Increase: 2023-07-06

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[alitoshmatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Tooltip is not shown for a new user on invite message page

What is the root cause of that problem?

UserDetailsTooltip is not working because only accountID was provided

App/src/components/MultipleAvatars.js

Line 186 in 619394d

<UserDetailsTooltip accountID={props.icons[0].id}>

What changes do you think we should make in order to solve the problem?

We don't have a data for new users in personalDetails that's why tooltip cannot retrieve any data. But we can provide fallback data to display available information about user like this:

fallbackUserDetails={{
                                    displayName: ReportUtils.getDisplayNameForParticipant(props.icons[1].id),
                                    login: lodashGet(props.icons[1], 'name',''),
                                    avatar: lodashGet(props.icons[1], 'source', ''),
                                }}

We should provide fallback data in every instance of tooltip in MultipleAvatars

What alternative solutions did you explore? (Optional)

[melvin-bot]

@NicMendonca Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[NicMendonca]

still reviewing this

[NicMendonca]

@priya-zha are those clickable on other platforms? Should they be clickable? 🤔

[priya-zha]

No. It's not about being clickable or not. Just try to hover over the avatar and notice that on hover, the tooltip isn't present for new users.

[NicMendonca]

@priya-zha my apologies, I understand now.

Any the other platforms? Can you make sure you are testing on all of those? We want to make sure we are ensuring parity. I was able to also reproduce on MacOS Desktop as an example:

[priya-zha]

I tested in on chrome (linux). Since it's related to tooltips, I could have tested it on Mac Os chrome or safari , but I don't have Mac to test them.

[shawnborton]

I think it makes sense to have the tooltip here out of consistency's sake. That being said, I think we just merged some code that touches this area so let's make sure it's still happening (cc @puneetlath)

[puneetlath]

I agree it makes sense to have the tooltip using the fallback details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01aa1190833be5a152

[melvin-bot]

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[thesahindia]

@alitoshmatov's proposal looks good!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @mountiny, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @Priya! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

The BZ member will need to manually hire priya for the Reporter role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

[alitoshmatov]

@thesahindia Looks like icons are now empty and just have avatar for user

The reason is that, OptionsListUtils.getAvatarsForAccountIDs is used, and only accoundIDs are passed here, although we have login info.

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Line 197 in e5b3394

icons={OptionsListUtils.getAvatarsForAccountIDs(_.values(this.props.invitedEmailsToAccountIDsDraft), this.props.personalDetails)}

And this method is setting default value as empty.

[alitoshmatov]

I think we should modify OptionsListUtils.getAvatarsForAccountIDs to also receive default values, or we can create a new method for this purpose

[thesahindia]

I think we should modify OptionsListUtils.getAvatarsForAccountIDs to also receive default values

Makes sense to me.

[alitoshmatov]

PR ready - #22693

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.41-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Avatar adding new users #22693

If no regressions arise, payment will be issued on 2023-07-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[NicMendonca]

@thesahindia will you be requesting payment via Expensify?

[NicMendonca]

@priya-zha can you please apply to the job? https://www.upwork.com/jobs/~01aa1190833be5a152

[NicMendonca]

@alitoshmatov you've been paid! 🎉

[NicMendonca]

bump @priya-zha @thesahindia ^^

[thesahindia]

@thesahindia will you be requesting payment via Expensify?

yup!

I think there is no need to add a regression test? And we can skip the other items of the checklist too since this couldn't have been caught. It was caused by a big PR

[NicMendonca]

@priya-zha - reporting bonus $250
@alitoshmatov - Contributor - $1,500
@thesahindia - C+ $1,500 (paid via Expensify)

[NicMendonca]

@priya-zha just need you to accept the offer in Upwork please 🙏

[priya-zha]

@NicMendonca submitted the proposal. Apologies for the delay. I was out for a few days and didn't check the mail.

Thank you for the offer.

[NicMendonca]

@priya-zha you've been paid!

[NicMendonca]

Everyone has been paid!

@thesahindia don't forget to request payment via Expensify.

@priya-zha - reporting bonus $250
@alitoshmatov - Contributor - $1,500
@thesahindia - C+ $1,500 (paid via Expensify)

[JmillsExpensify]

Reviewed the details for @thesahindia. $1,500 approved for payment in NewDot based on the BZ summary above.