[HOLD for payment 2023-07-21] [$1000] Inconsistency - Link previews have different border color than quotes

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app.
2. Send a quote message in any chat. ex - > hello.
3. Send a link. ex - google.com and wait for the link preview to appear.
4. Notice that the left border has a different color in both cases.

Expected Result:

Border color should be consistent for both link previews and quote.

Actual Result:

Border color is different for both link preview and quote.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.33-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-28.at.9.01.07.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @Nikhil-Vats Bortman
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687966486390789

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01034485de0b01882f
• Upwork Job ID: 1676724101797347328
• Last Price Increase: 2023-07-05

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

by @Nikhil-Vats

Please re-state the problem that we are trying to solve in this issue.

Left border color for link previews is inconsistent with blockquote's left border color.

What is the root cause of that problem?

We are using a different color for link previews left border.

App/src/styles/styles.js

Lines 3364 to 3369 in a23d161

	linkPreviewWrapper: {
	marginTop: 16,
	borderLeftWidth: 4,
	borderLeftColor: getTransparentColor(themeColors.inverse, 33),
	paddingLeft: 12,
	},

App/src/styles/styles.js

Lines 2680 to 2681 in a23d161

	blockquote: {
	borderLeftColor: themeColors.border,

What changes do you think we should make in order to solve the problem?

We should just change the border color used for link previews to be the same as other one - themeColors.border.
Optionally, we can also remove the function getTransparentColor which was added for link previews border color and is only used there.

What alternative solutions did you explore? (Optional)

NA

[Nikhil-Vats]

My proposal above.

[mallenexpensify]

@Nikhil-Vats you mean these two are different colors, right?

[Nikhil-Vats]

Yes @mallenexpensify .

[Nikhil-Vats]

@mallenexpensify This was reported by Shawn here and @wojtus7 provided confirmation here.

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01034485de0b01882f

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[mallenexpensify]

Thanks @Nikhil-Vats, moving this along

[mallenexpensify]

@aimane-chnaif , please review @Nikhil-Vats 's proposal above

[aimane-chnaif]

@Nikhil-Vats's proposal looks good. Straightforward fix.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[marcochavezf]

Thanks for the review @aimane-chnaif, assigning @Nikhil-Vats 🚀

[melvin-bot]

📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[melvin-bot]

📣 @Nikhil-Vats 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @nikhil! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

The BZ member will need to manually hire Nikhil for the Reporter role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

[Nikhil-Vats]

@aimane-chnaif @mallenexpensify @marcochavezf PR is ready for review.

[Nikhil-Vats]

@thienlnam Melv incorrectly identifies the reporter as it doesn't consider '-' in the GH handle for reporter only (it works well for assignee). Is this a known issue?

@mallenexpensify This issue was actually reported by @shawnborton here. I just created the bug report for it so you can remove me from the issue description as bug reporter.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: link preview border color #22677

If no regressions arise, payment will be issued on 2023-07-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mallenexpensify]

Thanks @Nikhil-Vats , I opened an internal GH to address the - bug. Removed ya from the OP for bug reporter too.

[melvin-bot]

@marcochavezf, @mallenexpensify, @Nikhil-Vats, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

@aimane-chnaif and @Nikhil-Vats paid $1500 each, inc. urgency bonus. Apologies for the delay, I was OOO a couple days.
@aimane-chnaif , please fill out the checklist above.
#21882 (comment)

[mallenexpensify]

For auditing, posting the format below

Issue reporter: none
Contributor: @aimane-chnaif $1500 paid via Upwork, inc. urgency bonus
Contributor+: @Nikhil-Vats $1500 paid via Upwork, inc. urgency bonus

@aimane-chnaif can you please fill out the checklist above so we can close this issue? Thx

[aimane-chnaif]

Preview link with quote message was missing test case while implementing new feature of link preview in #17288.
This was minor style inconsistency and I don't think regression test step is needed.