[HOLD for payment 2023-07-12] [HOLD for payment 2023-07-10] [$1000] Date is not being displayed correctly when single digit day is entered

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to ND
2. Open Settings
3. Open Profile
4. Open Personal Details
5. Click on Date of Birth
6. Choose the date 1 June, 2023 > Save Changes

Expected Result:

The date is fully visible

Actual Result:

The date is not fully visible

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.31-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

WhatsApp.Video.2023-06-17.at.15.20.12.mp4

SVDK7066.1.MP4

Expensify/Expensify Issue URL:
Issue reported by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686991387615589

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01046c3f7c49b615ed
• Upwork Job ID: 1673481863409926144
• Last Price Increase: 2023-06-27

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kevinksullivan]

taking to slack thread since I cannot reproduce

[Pujan92]

@kevinksullivan It gets truncated when you select a date between 1 to 9.

[melvin-bot]

@kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kevinksullivan]

ha, got it. I updated the steps to make that a bit clearer.

[kevinksullivan]

Reproduced and sending to the pool

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01046c3f7c49b615ed

[melvin-bot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The date is not fully visible

What is the root cause of that problem?

It's this line where we're using white-space: pre

App/src/components/MenuItem.js

Line 83 in 48d4187

styles.pre,

. For some cases like above when the calculated width of the Text is smaller than the actual width, the Text will show ellipsis.

What changes do you think we should make in order to solve the problem?

We just need to make the Text takes full available width, for example by adding styles.flex1 or styles.w100 below this line

App/src/components/MenuItem.js

Line 85 in 48d4187

isDeleted ? styles.offlineFeedback.deleted : undefined,

.

What alternative solutions did you explore? (Optional)

We might want to check other places, it might have the same issues and can apply the same fix.

[mananjadhav]

@dukenv0307's proposal here looks good. I think we should focus on MenuItem because this itself will require testing across the app where we're using the component.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[manjesh-yadav]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Date is not being displayed correctly when single digit day is entered

What is the root cause of that problem?

The actual problem with our ExpensifyNeue and ExpensifyMono font, In our font whitespace is not handled for the IOS Safari browser. When you change the font which is supported like 14px -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Helvetica, Arial, sans-serif it's works fine

We do not set Text component with full width or flex as proposed above it causes another problem when we use this with the icon, we already used it in 'src/components/MoneyRequestHeader.js:187'

When set full width or flex @mananjadhav

What changes do you think we should make in order to solve the problem?

When we set white-space: pre whitespace is preserved by the browser and the browser handled itself and it course problem

We can remove this style or replace a property nowrap then it's work normally and Text will wrap when necessary
App/src/components/MenuItem.js

-  styles.pre

or

-  styles.pre
+ styles.noWrap

It always works fine in a single line because we already use numberOfLines={1}

Result

Text ellipsis problem

Text does not ellipsis with an icon

Large text in a single line

What alternative solutions did you explore? (Optional)

1. Change our font family
2. Correct whitespace of our ExpensifyNeue and ExpensifyMono font

[melvin-bot]

📣 @dukenv0307 You have been assigned to this job by @cristipaval!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[kevinksullivan]

Hi @dukenv0307 , what melvin said ^ 😄 . Please apply for the job in upwork as I'm not sure what your name would be for searching it. Thanks!

[kevinksullivan]

Offer sent for C+ @mananjadhav

[melvin-bot]

@mananjadhav, @cristipaval, @kevinksullivan, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mananjadhav]

@kevinksullivan did you get a chance to look at the previous comment?

[kevinksullivan]

@mananjadhav so are you asking for the standard $1,000 then?

[mananjadhav]

@kevinksullivan Yes the standard 1000$.

[mananjadhav]

@kevinsullivan did you get a chance to look at my previous comment? This is pending for payout.

[kevinsullivan]

@kevinsullivan did you get a chance to look at my previous comment? This is pending for payout.

Please let me know what I need to do
Thank you. Kevin

PS I think you meant @kevinksullivan.

[melvin-bot]

📣 @kevinsullivan! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[mananjadhav]

Apologies for the issue. Yes I meant to tag @kevinksullivan

[kevinsullivan]

Thank you, no problem

…

On Tue, Jul 18, 2023, 12:44 PM Manan ***@***.***> wrote: Apologies for the issue. Yes I meant to tag @kevinksullivan <https://github.com/kevinksullivan> — Reply to this email directly, view it on GitHub <#21404 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAVEX5MN34P5ZEUHUZFIYBDXQ24QVANCNFSM6AAAAAAZRTBQ7I> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[kevinksullivan]

Paid out

[mananjadhav]

Thanks the payout @kevinksullivan. Is it possible to do a refund without additional charges? I am currently raising requests from NewDot.

[kevinksullivan]

So you already got paid for this in newdot @mananjadhav ?

[mananjadhav]

DMed you @kevinksullivan.

[kevinksullivan]

just sent a refund request @mananjadhav

[mananjadhav]

Thanks @kevinksullivan.

[anmurali]

Approved 1000 to Manan based on #21404 (comment), which has been refunded on Upwork!

[dukenv0307]

@kevinksullivan The PR is merged within 3 working days so I think I am eligible for a bonus timeline

[mananjadhav]

@dukenv0307 We missed a case here, hence this isn't eligible for the timeline bonus.