[HOLD for payment 2023-07-05] [$1000] Web - Chat - Mention list doesn't display when enter special key: '_-+=|\;`~ before:

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Enter special key and @he (ex: _@he or `@he or ~@he)

Expected Result:

The mention suggestion display

Actual Result:

The mention suggestion doesn't display

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.24.4

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @dukenv0307

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685529049518369

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018585a2ed09409031
• Upwork Job ID: 1666822250965151744
• Last Price Increase: 2023-06-22

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

In this PR: #19004 we don’t add some special keys ’_-=|;`~ in the SPECIAL_CHAR_OR_EMOJI and MENTION_REPLACER regex

What changes do you think we should make in order to solve the problem?

Add _-=|;`~ key to both SPECIAL_CHAR_OR_EMOJI and MENTION_REPLACER regex (don’t add + key because this key maybe exist in email)

What alternative solutions did you explore? (Optional)

[dukenv0307]

Re-post the proposal for more detail

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Chat - Mention list doesn't display when enter special key: '_-+=|;`~ before:
Also happen in the emoji suggestion

What is the root cause of that problem?

We could check this PR for more context. This PR misses some special keys

In here

App/src/pages/home/report/ReportActionCompose.js

Line 558 in 78aa3ba

const words = leftString.split(CONST.REGEX.SPECIAL_CHAR_OR_EMOJI);

We are using this regex

App/src/CONST.js

Line 1129 in 6e7f460

SPECIAL_CHAR_OR_EMOJI:

This regex doesn't include all special keys like '_-+=|;`~ so if we enter these keys before @ (to mention) or : (to display emoji), these keys will be included in the search word then no result found and the suggestion will not display

I just checked on Slack if we enter some special key before @ or : and check whether the suggestion is displayed or not
This is the result

Header	Slack	Expensify
_	yes	no
-	yes	no
+	yes (if after is :) and no (if after is @)	no
=	no	no
|	no	no
\	no	no
;	no	no
`	no	no
~	no	no
@	no	no

What changes do you think we should make in order to solve the problem?

We need to confirm that which special key stands before @ or : then we should show suggestions

Confirmed below

we should add \ ; ` to SPECIAL_CHAR_OR_EMOJI and should also to MENTION_REPLACER regex like this

Result

Screen.Recording.2023-06-23.at.11.52.27.mov

[sonialiap]

Reproducible 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018585a2ed09409031

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

Triggered auto assignment to @PauloGasparSv (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[sonialiap]

@abdulrahuman5196 we have a couple of proposals for this one already, have you had a chance to review them. Do either of them look good to start working on a solution?

[abdulrahuman5196]

yes will do today

[abdulrahuman5196]

I think the question here by @dukenv0307 is something we should think about before picking up a solution

We need to confirm that which special key stands before @ or : then we should show suggestions
IMO

If we start allowing characters before '@', how do we plan to different for emails? If we think '+' as valid before character of mention then the emails will be clashing with it for eg 'abdul+@gmail.com', mentions would come in this case if I try to input email Id.

@PauloGasparSv @sonialiap

[abdulrahuman5196]

@PauloGasparSv @sonialiap Ping on the above

[PauloGasparSv]

Thks for bringing this up @abdulrahuman5196.

IMO the behaviour we have right now is great and I don't think we should change that. Let's wait for @sonialiap's thoughts on this too!

Btw, I think we almost discussed if this was worth solving in the first place but then we created the GH anyways.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[PauloGasparSv]

Oh, I just realized that @sonialiap is OOO until EOW

IMO this doesn't really need to be discussed further and we should just Do Nothing because there is no real reason for the expected results.

[dukenv0307]

I think we should not add/accept these special characters because they are allowed in emails and pretty common:
_ + - @ ~ |

@PauloGasparSv So will we add/accept these characters \ ' ; `

[PauloGasparSv]

@PauloGasparSv So will we add/accept these characters \ ' ; `

Yes to: \ ; `
No to: '

So the list of accepted should be the following IMO:
, / \ ? " { } [ ] ( ) & ^ % $ # < > ! * = ` ;

And let's not add these characters there were discussed here at some point:
_ + - @ ~ | '

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[dukenv0307]

Agree with @PauloGasparSv suggestion and I also update proposal

[abdulrahuman5196]

@PauloGasparSv I agree we should add a lower subset of character which don't clash with existing experiences. Even if people want to add more we can do it in future if required. (Which i highly doubt will happen)

[abdulrahuman5196]

@dukenv0307 In the proposed changes, Since this is a regex change, kindly mention how you would change the regex to make this working.

Add _-=|;`~ key to both SPECIAL_CHAR_OR_EMOJI and MENTION_REPLACER regex (don’t add + key because this key maybe exist in email)

This doesn't provide complete information on how you would like to change the regex.

[dukenv0307]

@abdulrahuman5196 Thanks. I just update my proposal for more detail

cc @PauloGasparSv

[abdulrahuman5196]

@dukenv0307 's proposal here #20401 (comment) looks good and works well.

We can add characters based on @PauloGasparSv 's comment here #20401 (comment)

🎀👀🎀
C+ Reviewed

cc: @PauloGasparSv

[PauloGasparSv]

Nice, thks for all the help on defining the scope of this change @abdulrahuman5196 and @dukenv0307!

Assigning @dukenv0307 here

[melvin-bot]

📣 @dukenv0307 You have been assigned to this job by @PauloGasparSv!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dukenv0307]

@abdulrahuman5196 The PR is ready for review

[melvin-bot]

🎯 ⚡️ Woah @abdulrahuman5196 / @dukenv0307, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @dukenv0307 got assigned: 2023-06-23 16:14:07 Z
• when the PR got merged: 2023-06-26 18:30:57 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.33-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: display mention suggestion when typing \ ; ` before #21395

If no regressions arise, payment will be issued on 2023-07-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abdulrahuman5196]

BZ checklist

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression. The characters in discussion was not previously added.

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No. This is a minor case and wouldn't we beneficial to add a regression test.

[sonialiap]

@dukenv0307 offer sent for report + fix (+bonus) - paid ✔️
@abdulrahuman5196 offer sent for review (+bonus) - paid ✔️

[abdulrahuman5196]

@sonialiap accepted the offer