Web- Tooltip isn't showing for continuous carousel unlike Slack

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot on web chrome
2. Go to any chat and send 4 images
3. Click on the first image to preview and click on next arrow button continuously and see that the tooltip doesn't show for continuous movement
4. Follow the same steps on slack and see that on continuous navigation tooltip is shown. Since we follow the similar slack functionality , tooltip should be shown

Expected Result:

Tooltip should be shown on continuous carousel movement

Actual Result:

Tooltip is not shown on continuous carousel movement unlike Slack

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.19.2

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

error-2023-05-25_09.53.23.mp4

Recording.2862.mp4

Expensify/Expensify Issue URL:

Issue reported by: @avi-shek-jha

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684988066381189

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tooltip isn't showing for continuous carousel

What is the root cause of that problem?

The root cause of this issue is that when the button is clicked, a blur event gets fired which has a relatedTarget value of null. This causes the condition here to return false, causing the Hoverable to set Hovered state as false.

What changes do you think we should make in order to solve the problem?

We can edit this check to be something like:

    if (!this.wrapperView.contains(el.relatedTarget || el.currentTarget)) {

What alternative solutions did you explore? (Optional)

None

[avi-shek-jha]

@kbecciv I have reported this issue and seems like you've assigned someone else with the same name. My GH handle is : @avi-shek-jha. It would be great if you could update the initial reporter name. Thanks

[huzaifa-99]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

My RCA is basically the same as @allroundexperts, that we are blurring the button on click which causes the tooltip to not show.

What changes do you think we should make in order to solve the problem?

I think we don't have to blur every button on click like we do in Button/index.js#L251.

We should add a prop blurOnPress (default: true) to the Button and update this check

App/src/components/Button/index.js

Line 250 in 414dc10

if (e && e.type === 'click') {

to only blur the button when blurOnPress is true

if (e && e.type === 'click' && this.props.blurOnPress) {

and in the AttachmentCarousel in the previous and next buttons we should pass the blurOnPress as false

What alternative solutions did you explore? (Optional)

N/A

[MrJithil]

Seems a duplicate of #19693

[JmillsExpensify]

Based on a review of that issue, I agree. Closing, but comment if you disagree with @MrJithil's latest post.

[priya-zha]

@JmillsExpensify This bug was already a duplicate of the bug here which was created earlier on April. According to you and @MrJithil , if this bug is a duplicate of 19693 bug, then I think 19693 should also be the duplicate of 17307. Please let me know your thoughts on this.

[huzaifa-99]

@JmillsExpensify I don't think those are related, as the root cause and fix for both of them are different.

• For this issue, the RCA is we are are blurring the button on press which hides the tooltip.
• For 19693, the RCA is related to the tooltip animation. I added more explanation here in my proposal for 19693