Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Focus is applied and automatically removed from the emoji search field #19542

Closed
1 of 6 tasks
kavimuru opened this issue May 24, 2023 · 28 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kavimuru
Copy link

kavimuru commented May 24, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open an existing chat
  2. Send money/ request money
  3. Right-click on the bottom end of the settle up/ owes message
  4. Click on add emoji icon

Expected Result:

Focus should remain applied to the emoji search field

Actual Result:

Focus is applied to and then automatically removed from the emoji search field

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.17.3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.746.mp4
2023-05-23.14.26.30.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684841616606439

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e677976150240210
  • Upwork Job ID: 1661497540579950592
  • Last Price Increase: 2023-05-24
@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@zanyrenney zanyrenney added Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels May 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

Current assignee @zanyrenney is eligible for the Bug assigner, not assigning anyone new.

@Expensify Expensify deleted a comment from melvin-bot bot May 24, 2023
@Natnael-Guchima
Copy link

@zanyrenney It is not reproducible when you open the emoji dialog box using the hover-over flow. You have to go through the right-click flow to reproduce the issue. And also the place where you right-clicks matters too.

image

@zanyrenney
Copy link
Contributor

Dammit I deleted my comment accidentally:
2023-05-24_17-20-02 (1)

@zanyrenney
Copy link
Contributor

Ah nice thank you so much @Natnael-Guchima !

@zanyrenney
Copy link
Contributor

Able to repro:
2023-05-24_17-24-43 (1)

@zanyrenney zanyrenney removed the Needs Reproduction Reproducible steps needed label May 24, 2023
@chiragsalian
Copy link
Contributor

Discussed on slack with vit (here). We feel like this is not a blocker. I did a quick search and nothing stood out to me.
Removing deploy blocker label and marking it as external to be tackled.

@chiragsalian chiragsalian removed their assignment May 24, 2023
@chiragsalian chiragsalian added Daily KSv2 External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels May 24, 2023
@melvin-bot melvin-bot bot changed the title Focus is applied and automatically removed from the emoji search field [$1000] Focus is applied and automatically removed from the emoji search field May 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01e677976150240210

@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

Triggered auto assignment to @grgia (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@parasharrajat
Copy link
Member

NO proposals yet.

@hoangzinh
Copy link
Contributor

hoangzinh commented May 26, 2023

It seems the issue is fixed. I could reproduce several days ago but not now.

@parasharrajat
Copy link
Member

@Natnael-Guchima What do you think?

@Natnael-Guchima
Copy link

Natnael-Guchima commented May 26, 2023

@parasharrajat I will test this in an hour, and I will let you know if this is still reproducible.

@Natnael-Guchima
Copy link

@parasharrajat I can't reproduce this issue any longer. It seems that the issue is fixed somewhere on the last two releases: #19565 & #19422

@parasharrajat
Copy link
Member

Ok, Thanks. This is good to be closed @zanyrenney

@Natnael-Guchima
Copy link

You are welcome!

@Natnael-Guchima
Copy link

Natnael-Guchima commented May 27, 2023

Hello @zanyrenney👋,
I reported this issue when it was first introduced to staging, and initially, it was listed as a deploy blocker here. Now, it seems that the issue is fixed somewhere in the latest releases, and the fixing PR doesn't seem to be linked to this issue. Am I eligible for reporting bonus?

Thanks.

@melvin-bot melvin-bot bot added the Overdue label May 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 29, 2023

@parasharrajat, @grgia, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot removed the Overdue label May 30, 2023
@grgia grgia added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels May 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 30, 2023

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot

This comment was marked as resolved.

@grgia
Copy link
Contributor

grgia commented May 30, 2023

@puneetlath Zany's OOO so I reassigned the bug label. I wanted a BZ to double-check on this comment #19542 (comment) before we close this out

@puneetlath
Copy link
Contributor

@Natnael-Guchima paid you for the bug report.

Going to go ahead and close since this is fixed. Thanks everyone!

@Natnael-Guchima
Copy link

@Natnael-Guchima paid you for the bug report.

Going to go ahead and close since this is fixed. Thanks everyone!

Thanks, Puneet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

9 participants