[HOLD for payment 2023-07-26] [$1000] The chat composer is hidden and is not scrollable on a new page with a description/date

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot on mweb chrome
2. Click on + icon
3. Select send money > enter amount
4. Select a recipient > send the payment
5. Click I'll settle up elsewhere
6. Click on the payment request in the DM of the recipient
7. This takes you to a new screen where you can write a message under the payment request
8. Click on chat composer so that keyboard opens up
9. Notice that the top part of the composer is hidden
10. Additionally, if you type a long description, you can't see it
11. Also, you're unable to scroll the long description while the keyboard is open

Expected Result:

The chat composer should not be hidden on a new page with description and date after sending money

Actual Result:

The chat composer is hidden on a new page with description and date after sending money

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.16-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

composer.mp4

az_recorder_20230522_112100.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684475099942009

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01beba9fa9a0c7d961
• Upwork Job ID: 1661041516743192576
• Last Price Increase: 2023-06-13

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[NicMendonca]

Going OOO until June 5th so assigning a buddy to this GH to watch over the issue. I'll pick it back up when I am back from OOO/ if this is still open.

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01beba9fa9a0c7d961

[melvin-bot]

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

Triggered auto assignment to @madmax330 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[akinwale]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The chat composer is hidden and not scrollable on the money request page.

What is the root cause of that problem?

The MoneyRequestHeader component occupies too much space on mobile screens, which causes it to overlap and hide the chat area when the soft keyboard is visible. This also happens in iOS Safari and results in poor usability on both Android and iOS native.

From the code listing at https://github.com/Expensify/App/blob/main/src/components/MoneyRequestHeader.js#L177-L193, we can see that each piece of information is laid out one after the other which occupies too much vertical space for smaller screens.

What changes do you think we should make in order to solve the problem?

Automatically adjust the layout of the MoneyRequestHeader component to rearrange and display the information for more compact screens. The header could be conditionally resized based on whether or not the soft keyboard is visible as shown in the video demo.

For the compact view, we could one or more of the following:

• Use a 2-column layout
• Hide the description
• Reduce the vertical spacing between the sections.

What alternative solutions did you explore? (Optional)

Alternatively, always display a compact version of the money request header for mobile screens.

money-request-header.mp4

[maddylewis]

i'll let @aimane-chnaif review this most recent proposal and confirm if that's how we should move forward.

[madmax330]

Waiting on proposal reviews @aimane-chnaif

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

[NicMendonca]

^ sorry, was just checking to see if that would re-create the job in Upwork since the original job post expired 👼

[NicMendonca]

@ShogunFire here's the job post! https://www.upwork.com/jobs/~016e8237e6e708015c

@aimane-chnaif are you requesting payment via Expensify?

[ShogunFire]

@NicMendonca Sorry but can you invite me ? I have already applied on another issue so I think they have stored my profile for next time and I don't want to use 16 connects on all my current issues

[aimane-chnaif]

@aimane-chnaif are you requesting payment via Expensify?

Still upwork

[NicMendonca]

@ShogunFire I can't find you to invite, you are not searchable via GH username. Can you please link your Upwork or apply to the job here: https://www.upwork.com/jobs/~016e8237e6e708015c

@aimane-chnaif thanks! Just sent you the offer

[ShogunFire]

https://www.upwork.com/freelancers/pierremichel5

[NicMendonca]

@aimane-chnaif you've been paid 🎉

@ShogunFire just need you to accept the offer, please

[NicMendonca]

@aimane-chnaif bump on the BZ checklist also: #19389 (comment)

[NicMendonca]

@ShogunFire you've been paid! 🎉

[NicMendonca]

@aimane-chnaif bump on BZ checklist pls!

[aimane-chnaif]

This is a new feature, not bug.

[NicMendonca]

everyone has been paid!

[priya-zha]

@NicMendonca I'm the external reporter. I think I haven't been paid for this yet.

[NicMendonca]

@priya-zha sorry! I was getting confused by another GH.

Can you please apply to the job? https://www.upwork.com/jobs/~016e8237e6e708015c

[priya-zha]

@NicMendonca submitted the proposal. Thanks

[NicMendonca]

@priya-zha you've been paid! sorry again!

[ShogunFire]

@NicMendonca Hello, sorry for the late request but could you put the upwork mission as completed ? Because it makes my upwork profile worse otherwise. Thanks

[stephanieelliott]

Hello, sorry for the late request but could you put the upwork mission as completed ? Because it makes my upwork profile worse otherwise. Thanks

I took care of this!