[$1000] [HOLD for payment 2023-06-13] Crash on split confirm

[amyevans]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

This is a follow up issue from #17349 (comment)

Action Performed:

1. (Precondition) Have the desktop app open but not logged in; optionally, throttle your network (see last step)
2. Log in to web
3. In a 1:1 DM, select Send money
4. Copy the URL from the address bar
5. Modify the URL so that it's a deep link (replace http with new-expensify) and open it
6. Follow the deep link prompt to open it in desktop
7. Enter an amount to split and click Next button very quickly (if you are not throttling your network)

Expected Result:

Split confirm page should open

Actual Result:

The app crashes

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

split.confirm.crash.mov

19234-repro-780.mov

Expensify/Expensify Issue URL:
Issue reported by: @aimane-chnaif
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010f9b81ec5ac80063
• Upwork Job ID: 1668641221032722432
• Last Price Increase: 2023-06-13

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[amyevans]

@jczekalski please comment on the issue so I can assign you

[jczekalski]

@amyevans

[jczekalski]

@amyevans I pulled the changes from the latest version of main and started looking into this. If I quickly open the Send Money page using slow 3G network throttling or deep link into the page (http://localhost:8080/send/new) I get these errors:

tNumberFormatUnitOptions.js:18 Uncaught TypeError: currency cannot be undefined
The above error occurred in the <TextInputWithCurrencySymbol> component:

Uncaught (in promise) TypeError: Cannot read properties of null (reading 'style')
   at eval (index.js:11:1)

Screen.Recording.2023-05-19.at.14.10.58.mov

So I can't get to the confirmation screen without the app crashing. In the video you uploaded, the Send Money page works fine and the errors in the console are different (the app crashes once the confirmation page is opened). It looks like these are new issues, do you know if they've been reported?

[amyevans]

We have over 1,000 open issues in the repo, so I don't know off the top of my head if they've been reported yet haha. Could you post them in the #expensify-bugs Slack channel? Our QA team is better at spotting duplicates, and if they aren't dupes they will create new issues for them.

[jczekalski]

We have over 1,000 open issues in the repo, so I don't know off the top of my head if they've been reported yet haha. Could you post them in the #expensify-bugs Slack channel? Our QA team is better at spotting duplicates, and if they aren't dupes they will create new issues for them.

Good point! Sorry, I'm still getting used to this setup :) I posted the bug in the #expensify-bugs channel.

Update: Issue created based on the bug report: #19435

[jczekalski]

Update: I approved the PR which fixes the bug I mentioned above (crash on Send money / Request money / Split bill), so we should be able to work on this issue once it has been merged.

[kowczarz]

I'm from Software Mansion, I'd like to work on this job.

[melvin-bot]

📣 @kowczarz! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[jczekalski]

@amyevans Could you reassign the issue to @kowczarz?

[kowczarz]

I'm not able to reproduce the issue any more

Screen.Recording.2023-05-25.at.14.52.11_H.265.mp4

[amyevans]

Greg and I both just spent some time attempting to reproduce as well and weren't able. I'm going to close. Thanks guys!

[aimane-chnaif]

@amyevans @kowczarz here's clear reproducible step:
(key to reproduce: go to 1:1 chat > Send money)

Screen.Recording.2023-05-25.at.3.57.50.PM.mov

[amyevans]

Okay thanks, reproduced and wrote up some clearer steps - let me know if they can be tweaked for clarity:

19234-repro-780.mov

1. (Precondition) Have the desktop app open but not logged in; throttle your network
2. Log in to web
3. In a 1:1 DM, select Send money
4. Copy the URL from the address bar
5. Modify the URL so that it's a deep link (replace http with new-expensify) and open it
6. Follow the deep link prompt to open it in desktop
7. Enter an amount to split

[aimane-chnaif]

@amyevans Desktop app should be auto-logged in if deep link comes from logged in web url. Not sure why that doesn't work from your video. Btw, that's out of topic for this issue.

Reproducible step makes sense. To reproduce easily even with fast network, 7. can be updated like this:
7. Enter amount and click Next button very quickly

[greg-schroeder]

PR is up!

[greg-schroeder]

PR review is very nearly complete

[greg-schroeder]

Merged, awaiting deploy to prod

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.24-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix crash on split confirm #19875

If no regressions arise, payment will be issued on 2023-06-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - @aimane-chnaif
• Contributor that fixed the issue - @kowczarz
• Contributor+ that helped on the issue and/or PR - @aimane-chnaif

https://www.upwork.com/jobs/~010f9b81ec5ac80063

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010f9b81ec5ac80063

[greg-schroeder]

Added the label to create an Upwork job, sorry for pings

[greg-schroeder]

Sent an offer to @aimane-chnaif

[greg-schroeder]

Last step is the checklist @aimane-chnaif!

[aimane-chnaif]

No PRs caused regression. This issue always existed after implement IOU pages but not able to catch because hard to reproduce. This GH was even closed until I clarify clear reproducible video, which is edge case.
So I don't suggest regression test step. If anyone disagrees, we can use this for regression test step.

[greg-schroeder]

All right. Thanks for running through it. Paid out. Going to close.