[HOLD for payment 2023-05-22] [$1000] Company name is out of screen on Additional information page #18000

kavimuru · 2023-04-26T00:54:10Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to Settings > Workspaces >Connect bank account
click on connect manually
Enter routing number and account number
click on continue
fill up Company information and add long name as company name(like TestTestTestTestTestTestTestTestTestTestTestTestTestTestTestTestTestTestTest)
click on save and continue
fill up Personal information and click on save and continue
add your documents to onfido
check the company name on Additional information screen

Expected Result:

Company names should not be out of screen

Actual Result:

Company name is out of screen

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.5-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682405975539849

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01510a094cb737037e
Upwork Job ID: 1651437390189281280
Last Price Increase: 2023-04-27

MelvinBot · 2023-04-26T00:54:15Z

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

MelvinBot · 2023-04-26T00:54:19Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

gadhiyamanan · 2023-04-26T00:55:06Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Company name is out of screen on Additional information page

What is the root cause of that problem?

width is missing for below Text component

App/src/pages/ReimbursementAccount/ACHContractStep.js

Lines 191 to 194 in 0262812

    
           <Text> 
        
               {this.props.translate('beneficialOwnersStep.iOwnMoreThan25Percent')} 
        
               <Text style={[styles.textStrong]}>{this.props.companyName}</Text> 
        
           </Text>

App/src/pages/ReimbursementAccount/ACHContractStep.js

Lines 211 to 214 in 0262812

    
           <Text> 
        
               {this.props.translate('beneficialOwnersStep.someoneOwnsMoreThan25Percent')} 
        
               <Text style={[styles.textStrong]}>{this.props.companyName}</Text> 
        
           </Text>

What changes do you think we should make in order to solve the problem?

add style={[styles.w100]} to below Text component

App/src/pages/ReimbursementAccount/ACHContractStep.js

Line 191 in 0262812

<Text>

App/src/pages/ReimbursementAccount/ACHContractStep.js

Line 211 in 0262812

<Text>

Result

dhairyasenjaliya · 2023-04-26T05:43:55Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Company name is out of screen on Additional information page

What is the root cause of that problem?

The reason is we are using <CheckboxWithLabel> with LabelComponent which doest have any flex property so for that reason text is over flown in screen without adapting the width of the parent component

What changes do you think we should make in order to solve the problem?

We just need to wrap both nested <Text> component into <View> and add flex1 as style
Further for better code visibility we can improve by removing nested text and place as separate <Text> as nested is really not required here
Optionally we can also set number of line for company name limit
Also we are using same approach in RequestorStep.js as well make sense to add flex1 rather then fixed width
Optionally to match with CheckboxWithLabel -> label component we can additionally add styles.ml1 since that component has
Changes in page https://github.com/Expensify/App/blob/3bc9d8b5acb608a66bc4ec62b5750628fa3aafc4/src/pages/ReimbursementAccount/ACHContractStep.js

                            <CheckboxWithLabel
                                inputID="ownsMoreThan25Percent"
                                style={[styles.mb2]}
                                LabelComponent={() => (
+                                    <View style={[styles.flex1]}>
                                        <Text>
                                            {this.props.translate('beneficialOwnersStep.iOwnMoreThan25Percent')}
                                        </Text>
                                        <Text style={[styles.textStrong]}>{this.props.companyName}</Text>
+                                    </View>
                                )} 
                            />


                            <CheckboxWithLabel
                                inputID="hasOtherBeneficialOwners"
                                style={[styles.mb2]}
                                LabelComponent={() => (
+                                    <View style={[styles.flex1]}>
                                        <Text>
                                            {this.props.translate('beneficialOwnersStep.someoneOwnsMoreThan25Percent')}
                                        </Text>
                                        <Text style={[styles.textStrong]}>{this.props.companyName}</Text>
+                                    </View>
                                )} 
                            />

Optional changes inside <CheckboxWithLabel> we have predefined label component which doesn’t have the flex1 property which has also issue when we have we can add there as well

kadiealexander · 2023-04-27T04:05:20Z

Repro'd on version 1.3.6-0.

MelvinBot · 2023-04-27T04:05:33Z

Job added to Upwork: https://www.upwork.com/jobs/~01510a094cb737037e

MelvinBot · 2023-04-27T04:05:36Z

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

MelvinBot · 2023-04-27T04:05:43Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

MelvinBot · 2023-04-27T04:05:49Z

Triggered auto assignment to @roryabraham (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

dhairyasenjaliya · 2023-04-27T04:29:54Z

Proposal - 2

What is the root cause of that problem?

The reason is we are using with LabelComponent which doest have any flex property so for that reason text is overflown in the screen without adapting the width of the parent component

What changes do you think we should make in order to solve the problem?

To apply the fix at the global component we could wrap this.LabelComponent inside an <View> with flex1 style it will apply to all LabelComponent changes needed at CheckboxWithLabel.js

                        {this.LabelComponent && (
  +                      <View style={styles.flex1}>
                            <this.LabelComponent />
  +                     </View>
                        )}

Pujan92 · 2023-04-27T05:25:59Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Company name or any long text within CheckboxWithLabel labelcontent overflow from its parent width.

What is the root cause of that problem?

Default word-break for the text is normal and we are not providing any word-break strategy for it.

What changes do you think we should make in order to solve the problem?

Add styles.breakWord here which will break the long word if it requires and won't allow overflow.

App/src/components/CheckboxWithLabel.js

Line 112 in 6fb0969

styles.noSelect,

Result

roryabraham · 2023-04-27T22:30:51Z

Accepting @dhairyasenjaliya's proposal 2

MelvinBot · 2023-04-27T22:31:11Z

📣 @dhairyasenjaliya You have been assigned to this job by @roryabraham!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

dhairyasenjaliya · 2023-04-28T06:27:30Z

@roryabraham @eVoloshchak PR ready for review

melvin-bot · 2023-05-05T20:08:31Z

@eVoloshchak, @roryabraham, @dhairyasenjaliya, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot · 2023-05-09T20:08:08Z

@eVoloshchak, @roryabraham, @dhairyasenjaliya, @kadiealexander Still overdue 6 days?! Let's take care of this!

eVoloshchak · 2023-05-09T20:31:02Z

Not overdue, PR is in review

melvin-bot · 2023-05-15T08:01:26Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-05-15T08:01:27Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Wrap label component to fix overflow #18125

If no regressions arise, payment will be issued on 2023-05-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-05-15T08:01:29Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR: n/a - [HOLD for payment 2023-05-22] [$1000] Company name is out of screen on Additional information page #18000 (comment)
[@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
[@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
[@eVoloshchak] Determine if we should create a regression test for this bug.
[@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: n/a

kadiealexander · 2023-05-22T02:13:59Z

Sent contracts to everyone! No speed bonus based on:

Assigned: April 28 10:31pm (GMT+12)
Merged: May 10th 8:35am (GMT+12)

@eVoloshchak any thoughts on the checklist above?

gadhiyamanan · 2023-05-22T03:25:05Z

@kadiealexander accepted, thanks!

kadiealexander · 2023-05-23T01:17:07Z

Everyone has been paid except for @eVoloshchak, this payment is on hold until this list is completed. Thank you!

eVoloshchak · 2023-05-24T15:50:59Z

The PR that introduced the bug has been identified. Link to the PR: Not applicable, this was missed during the initial implementation in Add VBA flow Part 1 #3459 a long time ago
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This is purely a visual bug, we already have the necessary items in the checklist, I don't think additional discussion is required
Determine if we should create a regression test for this bug.
Is it easy to test for this bug? No (it's time consuming, requires you to enter a lot of information)
Is the bug related to an important user flow? Yes
Is it an impactful bug? No

This bug has a very low impact and can be reproduced only if you enter a really long company name, I'd say the regression tests isn't necessary here

kadiealexander · 2023-05-24T22:41:02Z

Thanks @eVoloshchak! Everyone is paid, appreciate your work on this one, everyone!

kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 26, 2023

melvin-bot bot assigned kadiealexander Apr 26, 2023

kadiealexander added the External Added to denote the issue can be worked on by a contributor label Apr 27, 2023

melvin-bot bot changed the title ~~Company name is out of screen on Additional information page~~ [$1000] Company name is out of screen on Additional information page Apr 27, 2023

melvin-bot bot assigned eVoloshchak Apr 27, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 27, 2023

melvin-bot bot assigned roryabraham Apr 27, 2023

This comment was marked as off-topic.

Sign in to view

roryabraham assigned dhairyasenjaliya Apr 27, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 27, 2023

dhairyasenjaliya mentioned this issue Apr 28, 2023

Wrap label component to fix overflow #18125

Merged

57 tasks

melvin-bot bot added the Reviewing Has a PR in review label Apr 28, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels May 15, 2023

melvin-bot bot changed the title ~~[$1000] Company name is out of screen on Additional information page~~ [HOLD for payment 2023-05-22] [$1000] Company name is out of screen on Additional information page May 15, 2023

melvin-bot bot removed the Reviewing Has a PR in review label May 15, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 21, 2023

kadiealexander closed this as completed May 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-05-22] [$1000] Company name is out of screen on Additional information page #18000

[HOLD for payment 2023-05-22] [$1000] Company name is out of screen on Additional information page #18000

kavimuru commented Apr 26, 2023 •

edited by melvin-bot bot

Loading

MelvinBot commented Apr 26, 2023

MelvinBot commented Apr 26, 2023 •

edited by kadiealexander

Loading

gadhiyamanan commented Apr 26, 2023 •

edited

Loading

dhairyasenjaliya commented Apr 26, 2023 •

edited

Loading

kadiealexander commented Apr 27, 2023

MelvinBot commented Apr 27, 2023

MelvinBot commented Apr 27, 2023

MelvinBot commented Apr 27, 2023

MelvinBot commented Apr 27, 2023

dhairyasenjaliya commented Apr 27, 2023

Pujan92 commented Apr 27, 2023

This comment was marked as off-topic.

roryabraham commented Apr 27, 2023

MelvinBot commented Apr 27, 2023

dhairyasenjaliya commented Apr 28, 2023

melvin-bot bot commented May 5, 2023

melvin-bot bot commented May 9, 2023

eVoloshchak commented May 9, 2023

melvin-bot bot commented May 15, 2023

melvin-bot bot commented May 15, 2023 •

edited by kadiealexander

Loading

melvin-bot bot commented May 15, 2023 •

edited by kadiealexander

Loading

kadiealexander commented May 22, 2023

gadhiyamanan commented May 22, 2023

kadiealexander commented May 23, 2023

eVoloshchak commented May 24, 2023

kadiealexander commented May 24, 2023 •

edited

Loading

[HOLD for payment 2023-05-22] [$1000] Company name is out of screen on Additional information page #18000

[HOLD for payment 2023-05-22] [$1000] Company name is out of screen on Additional information page #18000

Comments

kavimuru commented Apr 26, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

MelvinBot commented Apr 26, 2023

MelvinBot commented Apr 26, 2023 • edited by kadiealexander Loading

Bug0 Triage Checklist (Main S/O)

gadhiyamanan commented Apr 26, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

dhairyasenjaliya commented Apr 26, 2023 • edited Loading

Proposal

kadiealexander commented Apr 27, 2023

MelvinBot commented Apr 27, 2023

MelvinBot commented Apr 27, 2023

MelvinBot commented Apr 27, 2023

MelvinBot commented Apr 27, 2023

dhairyasenjaliya commented Apr 27, 2023

Pujan92 commented Apr 27, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

This comment was marked as off-topic.

roryabraham commented Apr 27, 2023

MelvinBot commented Apr 27, 2023

dhairyasenjaliya commented Apr 28, 2023

melvin-bot bot commented May 5, 2023

melvin-bot bot commented May 9, 2023

eVoloshchak commented May 9, 2023

melvin-bot bot commented May 15, 2023

melvin-bot bot commented May 15, 2023 • edited by kadiealexander Loading

melvin-bot bot commented May 15, 2023 • edited by kadiealexander Loading

kadiealexander commented May 22, 2023

gadhiyamanan commented May 22, 2023

kadiealexander commented May 23, 2023

eVoloshchak commented May 24, 2023

kadiealexander commented May 24, 2023 • edited Loading

kavimuru commented Apr 26, 2023 •

edited by melvin-bot bot

Loading

MelvinBot commented Apr 26, 2023 •

edited by kadiealexander

Loading

gadhiyamanan commented Apr 26, 2023 •

edited

Loading

dhairyasenjaliya commented Apr 26, 2023 •

edited

Loading

melvin-bot bot commented May 15, 2023 •

edited by kadiealexander

Loading

melvin-bot bot commented May 15, 2023 •

edited by kadiealexander

Loading

kadiealexander commented May 24, 2023 •

edited

Loading