Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-29] [HOLD for payment 2023-06-15] [$250] [Group 5][Accessible Pressable] Migrate PressableWithoutFocus #17046

Closed
roryabraham opened this issue Apr 6, 2023 · 25 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Apr 6, 2023

HOLD on #16988

Description

Migrate PressableWithoutFocus to use GenericPressable

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010687bce6db55a7ab
  • Upwork Job ID: 1666248467627630592
  • Last Price Increase: 2023-06-07
@roryabraham roryabraham added the NewFeature Something to build that is a new item. label Apr 6, 2023
@roryabraham roryabraham self-assigned this Apr 6, 2023
@MelvinBot

This comment was marked as resolved.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 6, 2023
@roryabraham roryabraham added Monthly KSv2 and removed Weekly KSv2 labels Apr 6, 2023
@roryabraham roryabraham changed the title [HOLD][Group 5][Accessible Pressable] Migrate PressableWithoutFocus [Group 5][Accessible Pressable] Migrate PressableWithoutFocus May 11, 2023
@melvin-bot melvin-bot bot added the Overdue label May 11, 2023
@robertKozik
Copy link
Contributor

I'll get that one

@muxriddinmuqimov77
Copy link

I want to work on it.

@roryabraham roryabraham added the External Added to denote the issue can be worked on by a contributor label Jun 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

Job added to Upwork: https://www.upwork.com/jobs/~010687bce6db55a7ab

@melvin-bot melvin-bot bot changed the title [Group 5][Accessible Pressable] Migrate PressableWithoutFocus [$1000] [Group 5][Accessible Pressable] Migrate PressableWithoutFocus Jun 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

Triggered auto assignment to @johncschuster (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Jun 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 7, 2023
@roryabraham roryabraham changed the title [$1000] [Group 5][Accessible Pressable] Migrate PressableWithoutFocus [$250] [Group 5][Accessible Pressable] Migrate PressableWithoutFocus Jun 7, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.25-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jun 14, 2023
@roryabraham
Copy link
Contributor Author

Hmmm I think something weird happened with this issue and it shouldn't be awaiting payment yet. The PR is still in review: #20202

@melvin-bot melvin-bot bot removed the Overdue label Jun 14, 2023
@robertKozik
Copy link
Contributor

robertKozik commented Jun 14, 2023

@roryabraham Yeah, there was my mistake, that I link wrong issue to PR - here Michał raised it up #17040 (comment)

@melvin-bot
Copy link

melvin-bot bot commented Jun 16, 2023

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

  • when @robertKozik got assigned: 2023-06-07 00:59:50 Z
  • when the PR got merged: 2023-06-16 19:50:09 UTC
  • days elapsed: 8

On to the next one 🚀

@melvin-bot melvin-bot bot added the Overdue label Jun 19, 2023
@roryabraham
Copy link
Contributor Author

PR not on staging yet.

@melvin-bot melvin-bot bot removed the Overdue label Jun 19, 2023
@johncschuster
Copy link
Contributor

@parasharrajat can you please apply to the Upwork job when you get a moment? I'll get payment issued shortly!

@roryabraham
Copy link
Contributor Author

Sorry @johncschuster, the HOLD for payment date is wrong here. The PR was only deployed to staging yesterday

@johncschuster
Copy link
Contributor

Thanks for the heads up @roryabraham!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jun 22, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-06-15] [$250] [Group 5][Accessible Pressable] Migrate PressableWithoutFocus [HOLD for payment 2023-06-29] [HOLD for payment 2023-06-15] [$250] [Group 5][Accessible Pressable] Migrate PressableWithoutFocus Jun 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter - Internal
  • Contributor that fixed the issue - @robertKozik
  • Contributor+ that helped on the issue and/or PR - @parasharrajat

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@roryabraham
Copy link
Contributor Author

This is ready for payment

@melvin-bot melvin-bot bot added the Overdue label Jul 10, 2023
@roryabraham
Copy link
Contributor Author

@parasharrajat how are you getting paid for this? Via NewDot? it's been ready to pay for a couple weeks now

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue labels Jul 10, 2023
@parasharrajat
Copy link
Member

Sorry about that. Still setting up the NewDot payments. I will have a proper update in the next 5 days.

@parasharrajat
Copy link
Member

Payment requested on NewDot.

@anmurali
Copy link

Approved $250 based on #17046 (comment)

@parasharrajat
Copy link
Member

@johncschuster Please close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Status: Done
Development

No branches or pull requests

9 participants