[HOLD for payment 2023-07-26] [$250] Migrate WorkspacesListPage.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/pages/workspace/WorkspacesListPage.js
  • type: React.Component
  • has state values: false
  • has refs: false
  • has context: false
  • lifecycle methods: none

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019e70e56c4c509da1
• Upwork Job ID: 1673399922762240000
• Last Price Increase: 2023-06-26

[MelvinBot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[marcaaron]

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

[muxriddinmuqimov77]

I can work on this issue when it goes to external

[s-alves10]

I'd love to work on this.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019e70e56c4c509da1

[melvin-bot]

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[Vishrut19]

Dibs?

[HezekielT]

I'd love to work on this.

[0xmiros]

I checked and confirmed @muxriddinmuqimov77 has no migration issue assigned right now.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[code0406]

I submitted the PR 10 days ago. #16310 (comment)
Please check it kindly. Thank you.

[hayata-suenaga]

@0xmiroslav can you check the PR? 🙇

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @code0406 got assigned: 2023-07-03 21:09:33 Z
• when the PR got merged: 2023-07-18 03:26:52 UTC
• days elapsed: 10

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Migrate/workspacelistpage issue/16310 #22248

If no regressions arise, payment will be issued on 2023-07-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify / @Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Is the checlist needed here? cc @0xmiroslav @hayata-suenaga

[0xmiros]

Is the checlist needed here? cc @0xmiroslav @hayata-suenaga

No need

[melvin-bot]

@jliexpensify, @Christinadobrzyn, @0xmiroslav, @hayata-suenaga, @code0406 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[hayata-suenaga]

The PR has been deployed to production

[jliexpensify]

Nice, thanks Hayata!

Payments:

• @code0406 (Contributor): $250
• @0xmiroslav (C+): $250

Upworks job here.

[jliexpensify]

Paid and job removed!