Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] Migrate BaseVideoChatButtonAndMenu.js to function component #16215

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 24 comments
Closed
1 task

[$250] Migrate BaseVideoChatButtonAndMenu.js to function component #16215

marcaaron opened this issue Mar 20, 2023 · 24 comments
Assignees
@puneetlath @mollfpr @neonbhai
Labels
Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Milestone
React Class Compo...

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023 •
edited by melvin-bot bot
Loading

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018423f6f3f85f8aca
  • Upwork Job ID: 1673400279055613952
  • Last Price Increase: 2023-06-26
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate BaseVideoChatButtonAndMenu.js to function component [HOLD][$250] Migrate BaseVideoChatButtonAndMenu.js to function component Apr 13, 2023
@marcaaron
Copy link
Contributor Author

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

@s-alves10
Copy link
Contributor

I'd love to work on this.

@marcaaron marcaaron added the NewFeature Something to build that is a new item. label Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Triggered auto assignment to @puneetlath (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@marcaaron marcaaron changed the title [HOLD][$250] Migrate BaseVideoChatButtonAndMenu.js to function component [$250] Migrate BaseVideoChatButtonAndMenu.js to function component Jun 26, 2023
@marcaaron marcaaron added the External Added to denote the issue can be worked on by a contributor label Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Job added to Upwork: https://www.upwork.com/jobs/~018423f6f3f85f8aca

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@neonbhai
Copy link
Contributor

I would like to work on this!

@olexyt
Copy link
Contributor

olexyt commented Jun 26, 2023

I would like to work on this.

@rayane-djouah
Copy link
Contributor

can I work on this?

@asadath1395
Copy link

I would love to work on this. Can i get this assigned?

@mollfpr
Copy link
Contributor

mollfpr commented Jun 27, 2023 •
edited
Loading

@puneetlath Who is going to be the winner?

It seems @s-alves10 got it first?

@mollfpr mollfpr mentioned this issue Jun 27, 2023
Closed
1 task
@puneetlath
Copy link
Contributor

Looks like @s-alves10 has 3 active issues assigned currently. So let's go with @neonbhai since they are the earliest poster who isn't currently working on any issues for us.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 27, 2023

📣 @neonbhai You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@Santhosh-Sellavel Santhosh-Sellavel mentioned this issue Jun 27, 2023
Closed
1 task
@sophiepintoraetz sophiepintoraetz mentioned this issue Jun 28, 2023
Closed
1 task
@melvin-bot melvin-bot bot added the Overdue label Jun 29, 2023
@mollfpr
Copy link
Contributor

mollfpr commented Jun 30, 2023

@neonbhai Any update on the PR?

@melvin-bot melvin-bot bot removed the Overdue label Jun 30, 2023
@puneetlath
Copy link
Contributor

@neonbhai will you be able to raise a PR in the next 48 hours? If not, I'll go ahead and assign someone else. Just let us know. Thanks!

@neonbhai
Copy link
Contributor

Hey @mollfpr @puneetlath yes. the PR is almost done. I'm just collecting the testing screenshots. The PR will be up in 24 hours!

@puneetlath
Copy link
Contributor

Great!

@neonbhai neonbhai mentioned this issue Jul 1, 2023
Merged
57 tasks
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jul 1, 2023
@neonbhai
Copy link
Contributor

neonbhai commented Jul 1, 2023

Hi @mollfpr @puneetlath, Please review the PR!

@puneetlath
Copy link
Contributor

@mollfpr let me know when you think you'll be done reviewing.

@puneetlath puneetlath added Weekly KSv2 and removed Daily KSv2 labels Jul 7, 2023
@neonbhai
Copy link
Contributor

neonbhai commented Jul 26, 2023 •
edited
Loading

Hi @puneetlath it has been 2+ weeks since the PR was merged! Can I please get paid on upwork?

Upwork Profile Link

@puneetlath
Copy link
Contributor

Oh, weird, sorry about that! Usually an automation runs to let me know it's time to pay.

@puneetlath
Copy link
Contributor

Upwork contracts sent. Sorry again for the delay!

@puneetlath
Copy link
Contributor

All paid. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@puneetlath puneetlath

@mollfpr mollfpr

@neonbhai neonbhai

Labels
Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
React Class Component Migration
Development

No branches or pull requests
10 participants
@puneetlath @shawnborton @PauloGasparSv @mollfpr @marcaaron @asadath1395 @neonbhai @rayane-djouah @olexyt @s-alves10