[HOLD for payment 2023-06-21] [$1000] Chat - Height of edit field is different for mWeb and native app @thesahindia

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Navigate to any chat
3. Send a message
4. Long press on it > Edit
5. Keep pressing enter and check the max height

Expected Result:

The height should be consistent

Actual Result:

The height isn't consistent

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.12.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @thesahindia

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1664197609260269

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @strepanier03 (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[Puneet-here]

Proposal

We need to keep the max lines 6 for isSmallScreenWidth and 16 when it's false

App/src/pages/home/report/ReportActionItemMessageEdit.js

Line 201 in f846519

maxLines={16} // This is the same that slack has

maxLines={this.props.isSmallScreenWidth ? 6 : 16}

we can keep add them in CONST.js

I think we should also check if it's a touch screen by canUseTouchScreen() we should also check the same here

App/src/pages/home/report/ReportActionCompose.js

Line 144 in f846519

maxLines: props.isSmallScreenWidth ? CONST.COMPOSER.MAX_LINES_SMALL_SCREEN : CONST.COMPOSER.MAX_LINES,

[strepanier03]

Triage notes:

This issue is repeatable.

Tested this on my Android using the new.expensify mobile app.

I was able to have a height much greater than 6 or 16, it seemed near infinite and I could keep increasing the height repeatedly.

[strepanier03]

I think even with a proposal, this should go to Eng according ot the linked SO. There's multiple moving parts to our transition to BZ and I think this Triage process will go away in it's current form soon, a DD was just released for reviews regarding it.

Based on this thread in Slack, I think I should still triage as normal for now, with this going to eng who can put the external label on it as needed??

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @sonialiap (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Current assignee @roryabraham is eligible for the External assigner, not assigning anyone new.

[roryabraham]

@Puneet-here's proposal looks good to me, but I'll let @rushatgabhane buddy-check it. I'm not sure if we need to check canUseTouchScreen or if just screen width is sufficient here.

[rushatgabhane]

@Puneet-here
question: In message edit, why is the max line height 6 for native? Shouldn't it be 16 because we're setting it over here?

App/src/pages/home/report/ReportActionItemMessageEdit.js

Line 201 in f846519

maxLines={16} // This is the same that slack has

Also, I'm curious why we should use canUseTouchScreen(), is it because it's mWeb only?

[Puneet-here]

@Puneet-here question: In message edit, why is the max line height 6 for native? Shouldn't it be 16 because we're setting it over here?

It's probably because of the styling

Also, I'm curious why we should use canUseTouchScreen(), is it because it's mWeb only?

I think it's good to use canUseTouchScreen() and isSmallScreenWidth because this way the height of composer won't change for desktop when we decrease the screen size

[rushatgabhane]

It's probably because of the styling

@Puneet-here I think we need to dive deeper then. Like which specific style is changing maxLine behavior for native only?

I think it's good to use canUseTouchScreen() and isSmallScreenWidth because this way the height of composer won't change for desktop when we decrease the screen size

Oh, I get you.
Desktop app is rarely resized to small width. And I think it's okay to change the height on desktop when the screen size is reduced to simplify the code a bit.

[sonialiap]

Job is posted to Upwork

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rushatgabhane]

won't be able to update the checklist until friday. please change this to a weekly

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: This is a new feature that wasn't possible in react native before. So, not applicable.

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: This is a new feature that wasn't possible in react native before. So, not applicable.

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This is a new feature that wasn't possible in react native before. So, not applicable.

4. Determine if we should create a regression test for this bug. I think yes?

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

   1. Launch the app
   2. Navigate to any chat
   3. Send a message
   4. Long press on it > Edit
   5. Keep pressing "Enter", until the compose box doesn't increase in size anymore
   6. Ensure that it has 6 (full) lines in total on both native and mWeb

[sonialiap]

Whoops, this didn't automatically change to Daily. I'm clocking off now but I'll get the payments set up tomorrow morning!

[rushatgabhane]

This is paid on new dot by Anu (Because only Anu and Jason can settle manual requests for now).
$500 because regression

[sonialiap]

Regression test request submitted.

@rushatgabhane feel free to close once this has been payed out

[roryabraham]

@rushatgabhane does not have triage or write access, so @rushatgabhane @JmillsExpensify @anmurali once payment is done here please close this issue. Going to make this weekly in the meantime.

[rushatgabhane]

pay ment is done. we can close this

[sonialiap]

Thanks for the confirmation, closing out

[thesahindia]

Actually the reporting compensation is due but no action is needed here. I will request the money on new dot.

[melvin-bot]

📣 @naveensingh! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[thesahindia]

Hey @sonialiap, can you please confirm that I am eligible for the reporting compensation on this one? I just requested the payment on new dot for this.

Also it looks like @naveensingh had reported a regression above (according to #11694 (comment))

[JmillsExpensify]

Awaiting payment summary for issue reporting.

[thesahindia]

Bump @sonialiap

[JmillsExpensify]

Reached out to @sonialiap via NewDot.

[sonialiap]

Confirming that thesahindia is eligible for the reporter bonus:

• @thesahindia report = $250

[JmillsExpensify]

$250 payment approved for @thesahindia based on summary above.