[HOLD for payment] [$500] Android - Composer is hidden by native emoji picker - Reported by @rushatgabhane

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login
2. Go to a chat with any user
3. Tap on compose box to open the virtual keyboard
4. Select the emoji picker from the native virtual keyboard

Expected Result:

composer is not hidden by native emoji picker

Actual Result:

composer is hidden by native emoji picker

Workaround:

unknown

Platform:

Where is this issue occurring?

• Android

Version Number: 1.1.88-14
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-20220823-023430.mp4

Expensify/Expensify Issue URL:
Issue reported by: @rushatgabhane
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661203695542579

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @abekkala (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[AndrewGable]

This doesn't seem like a deploy blocker to me.

[melvin-bot]

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

@jboniface Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@jboniface 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[dylanexpensify]

@JmillsExpensify shall we close this again? cc @rushatgabhane

[0xmiros]

I know there's already payment for #11087 fix but I'd appreciate if I am eligible for some more compensation here since the main concern of android keyboard issue is completely gone and this fixes lots of linked issues related to android keyboard as I mentioned here.
If not eligible, that's also fine.
Thanks

cc: @JmillsExpensify

[rushatgabhane]

@0xmiroslav how much do you think is a fair amount? And can you give details here about why

Wait, how is your comment related to this issue?

[0xmiros]

Wait, how is your comment related to this issue?

This issue has also been fixed by that PR. I already tested before-fix and after-fix (videos here).
I am not only talking about this issue but also all the fixed issues I mentioned here.
I commented here just for bounty discussion since this GH is the one which is open and external.

[rushatgabhane]

@dylanexpensify all yours then 😅

@0xmiroslav it'd be great if you can summarize what you think would be a fair amount and why

[dylanexpensify]

@0xmiroslav would you mind summarizing what you think would be a fair amount and why

[0xmiros]

@0xmiroslav would you mind summarizing what you think would be a fair amount and why

@dylanexpensify here's summary:

#10483
#10609
#11087
#12592
#12622
#13111 (fixes regression without reverting #12642)
#13152

My solution (#13106) fixes all of these issues related to android keyboard. Before my fix, all of these were clearly reproducible when using Gboard as device input method.
I found out that they had the same root cause (conflict between native keyboard handling and js keyboard handling) and removing KeyboardAvoidingView completely in android was my unique idea (no one tried).
Now most keyboard issues in native android are gone.

I am already compensated from #11087 so what I am requesting in this GH is optional.
I'd appreciate around 1.5k for bonus but it depends on your evaluation.
If I am not eligible for additional bounty, that's also fine to me.
Thanks

[JmillsExpensify]

Looks like this wasn't resolved while I was out, so I'll jump in now that I'm back. I think doubling the price of this issue is fair. That comes out to $1,000. @dylanexpensify is out for the holidays, and I think we still need to retest to ensure this is no longer a live issue. @mallenexpensify this might be a good one to take over since you're around over the holidays.

[mallenexpensify]

I co-assigned. I'll get to it over the holidays, maybe today but I got a lil bit to do before logging off in an ~hour. Bumped to Daily. Thanks for the patience @0xmiroslav

[melvin-bot]

@mallenexpensify, @rushatgabhane, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

Working on this @0xmiroslav , hoping to have an update tomorrow.

[mallenexpensify]

Thanks @0xmiroslav for helping us fix the android keyboard issues. I def saw multiple bug reports and GH issues for 'em.

For #11087 you were paid $3000, but $1000 was a bonus so, if we are discussing what compensation should be for a situation like this, we shouldn't take into account any bonuses for doing quick work. I don't think you were compensated for other related issues but I might have missed that. Generally speaking, for deciding on bonuses and partial payments, we've found it's best practice to use a percentage vs a dollar amount. So, for this issue, I think a 50% bonus is fair, and that'd be on the job price before the bonus, so $1000.

It's hard to standardize on a process for payment for a PR that fixes multiple bugs (and... similarly, multiple bug reports that are fixed by a single PR). I think it's safe to assume that we weren't sure what was going on, by creating the multiple issues it helped us figure it out and also provided a level of urgency since your PR would fix the bugs.

The bonus should be applied to #11087 since that's the main issue. I'll post over there and issue payment.

[mallenexpensify]

I believe this issue can be closed now since there isn't an associated/linked PR for this. Comment/reopen if ya want.

[0xmiros]

Thanks @mallenexpensify, I appreciate that much.