Merge pull request #23243 from dukenv0307/revert-22983-fix/22078

Revert "fix: The title field is cleared when the Confirm task button is pressed"
Expensify · Jul 20, 2023 · d774940 · d774940
2 parents be2c81f + ebfa41b
commit d774940
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/src/libs/actions/Task.js b/src/libs/actions/Task.js
@@ -203,6 +203,8 @@ function createTaskAndNavigate(parentReportID, title, description, assignee, ass
         {optimisticData, successData, failureData},
     );
 
+    clearOutTaskInfo();
+
     Navigation.dismissModal(optimisticTaskReport.reportID);
 }
 

diff --git a/src/pages/tasks/NewTaskPage.js b/src/pages/tasks/NewTaskPage.js
@@ -68,7 +68,6 @@ function NewTaskPage(props) {
     const [shareDestination, setShareDestination] = React.useState({});
     const [errorMessage, setErrorMessage] = React.useState('');
     const [parentReport, setParentReport] = React.useState({});
-    const shouldClearOutTaskInfoOnUnmount = React.useRef(false);
 
     const isAllowedToCreateTask = useMemo(() => _.isEmpty(parentReport) || ReportUtils.isAllowedToComment(parentReport), [parentReport]);
 
@@ -102,16 +101,6 @@ function NewTaskPage(props) {
         }
     }, [props]);
 
-    useEffect(
-        () => () => {
-            if (!shouldClearOutTaskInfoOnUnmount.current) {
-                return;
-            }
-            Task.clearOutTaskInfo();
-        },
-        [],
-    );
-
     // On submit, we want to call the createTask function and wait to validate
     // the response
     function onSubmit() {
@@ -130,7 +119,6 @@ function NewTaskPage(props) {
             return;
         }
 
-        shouldClearOutTaskInfoOnUnmount.current = true;
         Task.createTaskAndNavigate(parentReport.reportID, props.task.title, props.task.description, props.task.assignee, props.task.assigneeAccountID);
     }