Skip to content

Commit

Permalink
Merge pull request #47325 from Expensify/vit-removeReportFieldsBeta
Browse files Browse the repository at this point in the history
Remove the report fields feature beta
  • Loading branch information
nkuoch authored Aug 13, 2024
2 parents 91e492c + c53c4cc commit b6a0b56
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 12 deletions.
5 changes: 0 additions & 5 deletions src/libs/Permissions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ function canUseSpotnanaTravel(betas: OnyxEntry<Beta[]>): boolean {
return !!betas?.includes(CONST.BETAS.SPOTNANA_TRAVEL) || canUseAllBetas(betas);
}

function canUseReportFieldsFeature(betas: OnyxEntry<Beta[]>): boolean {
return !!betas?.includes(CONST.BETAS.REPORT_FIELDS_FEATURE) || canUseAllBetas(betas);
}

function canUseWorkspaceFeeds(betas: OnyxEntry<Beta[]>): boolean {
return !!betas?.includes(CONST.BETAS.WORKSPACE_FEEDS) || canUseAllBetas(betas);
}
Expand All @@ -54,7 +50,6 @@ export default {
canUseP2PDistanceRequests,
canUseWorkflowsAdvancedApproval,
canUseSpotnanaTravel,
canUseReportFieldsFeature,
canUseWorkspaceFeeds,
canUseNetSuiteUSATax,
};
11 changes: 4 additions & 7 deletions src/pages/workspace/WorkspaceMoreFeaturesPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ function WorkspaceMoreFeaturesPage({policy, route}: WorkspaceMoreFeaturesPagePro
const styles = useThemeStyles();
const {shouldUseNarrowLayout} = useResponsiveLayout();
const {translate} = useLocalize();
const {canUseReportFieldsFeature, canUseWorkspaceFeeds} = usePermissions();
const {canUseWorkspaceFeeds} = usePermissions();
const hasAccountingConnection = !isEmptyObject(policy?.connections);
const isAccountingEnabled = !!policy?.areConnectionsEnabled || !isEmptyObject(policy?.connections);
const isSyncTaxEnabled =
Expand Down Expand Up @@ -197,10 +197,7 @@ function WorkspaceMoreFeaturesPage({policy, route}: WorkspaceMoreFeaturesPagePro
Policy.enablePolicyTaxes(policyID, isEnabled);
},
},
];

if (canUseReportFieldsFeature) {
organizeItems.push({
{
icon: Illustrations.Pencil,
titleTranslationKey: 'workspace.moreFeatures.reportFields.title',
subtitleTranslationKey: 'workspace.moreFeatures.reportFields.subtitle',
Expand Down Expand Up @@ -228,8 +225,8 @@ function WorkspaceMoreFeaturesPage({policy, route}: WorkspaceMoreFeaturesPagePro
}
setIsReportFieldsWarningModalOpen(true);
},
});
}
},
];

const integrateItems: Item[] = [
{
Expand Down

0 comments on commit b6a0b56

Please sign in to comment.