Merge pull request #24305 from jscardona12/hotfix/23481

Change position: absolute for position:fixed in getNavigationModalCard
Expensify · Aug 9, 2023 · b3789c9 · b3789c9
2 parents f0558fd + 209cb76
commit b3789c9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/libs/Navigation/AppNavigator/AuthScreens.js b/src/libs/Navigation/AppNavigator/AuthScreens.js
@@ -219,7 +219,6 @@ class AuthScreens extends React.Component {
             // we want pop in RHP since there are some flows that would work weird otherwise
             animationTypeForReplace: 'pop',
             cardStyle: getNavigationModalCardStyle({
-                windowHeight: this.props.windowHeight,
                 isSmallScreenWidth: this.props.isSmallScreenWidth,
             }),
         };

diff --git a/src/styles/getNavigationModalCardStyles/index.website.js b/src/styles/getNavigationModalCardStyles/index.website.js
@@ -1,14 +1,12 @@
 import getBaseNavigationModalCardStyles from './getBaseNavigationModalCardStyles';
 
-export default ({windowHeight, isSmallScreenWidth}) => ({
+export default ({isSmallScreenWidth}) => ({
     ...getBaseNavigationModalCardStyles({isSmallScreenWidth}),
 
-    // This height is passed from JavaScript, instead of using CSS expressions like "100%" or "100vh", to work around
+    // position: fixed is set instead of position absolute to workaround Safari known issues of updating heights in DOM.
     // Safari issues:
     // https://github.com/Expensify/App/issues/12005
     // https://github.com/Expensify/App/issues/17824
     // https://github.com/Expensify/App/issues/20709
-
-    height: `${windowHeight}px`,
-    minHeight: `${windowHeight}px`,
+    position: 'fixed',
 });