Skip to content

Commit

Permalink
Merge pull request #44592 from nkdengineer/fix/44111-regression
Browse files Browse the repository at this point in the history
  • Loading branch information
blimpich authored Jul 2, 2024
2 parents 22bcc98 + adda93b commit 7f3f120
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 3 deletions.
5 changes: 5 additions & 0 deletions src/libs/CardUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,10 @@ function hasDetectedFraud(cardList: Record<string, Card>): boolean {
return Object.values(cardList).some((card) => card.fraud !== CONST.EXPENSIFY_CARD.FRAUD_TYPES.NONE);
}

function getMCardNumberString(cardNumber: string): string {
return cardNumber.replace(/\s/g, '');
}

export {
isExpensifyCard,
isCorporateCard,
Expand All @@ -150,4 +154,5 @@ export {
getCardDescription,
findPhysicalCard,
hasDetectedFraud,
getMCardNumberString,
};
2 changes: 1 addition & 1 deletion src/libs/actions/PaymentMethods.ts
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ function addPaymentCard(params: PaymentCardParams) {
const cardYear = CardUtils.getYearFromExpirationDateString(params.expirationDate);

const parameters: AddPaymentCardParams = {
cardNumber: params.cardNumber,
cardNumber: CardUtils.getMCardNumberString(params.cardNumber),
cardYear,
cardMonth,
cardCVV: params.securityCode,
Expand Down
2 changes: 1 addition & 1 deletion src/pages/settings/Subscription/PaymentCard/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function AddPaymentCard() {

const addPaymentCard = useCallback((values: FormOnyxValues<typeof ONYXKEYS.FORMS.ADD_PAYMENT_CARD_FORM>) => {
const cardData = {
cardNumber: values.cardNumber,
cardNumber: CardUtils.getMCardNumberString(values.cardNumber),
cardMonth: CardUtils.getMonthFromExpirationDateString(values.expirationDate),
cardYear: CardUtils.getYearFromExpirationDateString(values.expirationDate),
cardCVV: values.securityCode,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ function WorkspaceOwnerPaymentCardForm({policy}: WorkspaceOwnerPaymentCardFormPr
const addPaymentCard = useCallback(
(values: FormOnyxValues<typeof ONYXKEYS.FORMS.ADD_PAYMENT_CARD_FORM>) => {
const cardData = {
cardNumber: values.cardNumber,
cardNumber: CardUtils.getMCardNumberString(values.cardNumber),
cardMonth: CardUtils.getMonthFromExpirationDateString(values.expirationDate),
cardYear: CardUtils.getYearFromExpirationDateString(values.expirationDate),
cardCVV: values.securityCode,
Expand Down

0 comments on commit 7f3f120

Please sign in to comment.