remove redundant parameter

Expensify · Oct 18, 2023 · 5d73a1f · 5d73a1f
1 parent 5f78a22
commit 5d73a1f
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 9 deletions.
diff --git a/src/components/SettlementButton.js b/src/components/SettlementButton.js
@@ -193,7 +193,7 @@ function SettlementButton({
     const selectPaymentType = (event, iouPaymentType, triggerKYCFlow) => {
         if (iouPaymentType === CONST.IOU.PAYMENT_TYPE.EXPENSIFY || iouPaymentType === CONST.IOU.PAYMENT_TYPE.VBBA) {
             triggerKYCFlow(event, iouPaymentType);
-            BankAccounts.setPersonalBankAccountContinueKYCOnSuccess(true, ROUTES.ENABLE_PAYMENTS);
+            BankAccounts.setPersonalBankAccountContinueKYCOnSuccess(ROUTES.ENABLE_PAYMENTS);
             return;
         }
 

diff --git a/src/libs/actions/BankAccounts.ts b/src/libs/actions/BankAccounts.ts
@@ -58,8 +58,8 @@ function openPersonalBankAccountSetupView(exitReportID: string) {
 /**
  * Whether after adding a bank account we should continue with the KYC flow
  */
-function setPersonalBankAccountContinueKYCOnSuccess(shouldContinueKYCOnSuccess: boolean, onSuccessFallbackRoute: string) {
-    Onyx.merge(ONYXKEYS.PERSONAL_BANK_ACCOUNT, {shouldContinueKYCOnSuccess, onSuccessFallbackRoute});
+function setPersonalBankAccountContinueKYCOnSuccess(onSuccessFallbackRoute: string) {
+    Onyx.merge(ONYXKEYS.PERSONAL_BANK_ACCOUNT, {onSuccessFallbackRoute});
 }
 
 function clearPersonalBankAccount() {

diff --git a/src/pages/AddPersonalBankAccountPage.js b/src/pages/AddPersonalBankAccountPage.js
@@ -89,12 +89,11 @@ class AddPersonalBankAccountPage extends React.Component {
 
     exitFlow(shouldContinue = false) {
         const exitReportID = lodashGet(this.props, 'personalBankAccount.exitReportID');
-        const shouldContinueKYCOnSuccess = lodashGet(this.props, 'personalBankAccount.shouldContinueKYCOnSuccess', false);
         const onSuccessFallbackRoute = lodashGet(this.props, 'personalBankAccount.onSuccessFallbackRoute', '');
 
         if (exitReportID) {
             Navigation.dismissModal(exitReportID);
-        } else if (shouldContinue && onSuccessFallbackRoute && shouldContinueKYCOnSuccess) {
+        } else if (shouldContinue && onSuccessFallbackRoute) {
             PaymentMethods.continueSetup(onSuccessFallbackRoute);
         } else {
             Navigation.goBack(ROUTES.SETTINGS_WALLET);

diff --git a/src/types/onyx/PersonalBankAccount.ts b/src/types/onyx/PersonalBankAccount.ts
@@ -16,10 +16,7 @@ type PersonalBankAccount = {
     /** Any reportID we should redirect to at the end of the flow */
     exitReportID?: string;
 
-    /** Whether the flow should continue to kyc on success */
-    shouldContinueKYCOnSuccess?: boolean;
-
-    /** The route to navigate to onSuccess */
+    /** The route to redirect after adding PBA successfully */
     onSuccessFallbackRoute?: string;
 };