Merge pull request #21857 from dukenv0307/fix/21418

fix: disable all-members button on admin channel
Expensify · Jul 4, 2023 · 4eef8fe · 4eef8fe
2 parents a93c1a0 + 390b501
commit 4eef8fe
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 20 deletions.
diff --git a/src/pages/settings/Report/ReportSettingsPage.js b/src/pages/settings/Report/ReportSettingsPage.js
@@ -97,9 +97,12 @@ class ReportSettingsPage extends Component {
         const shouldDisableRename = this.shouldDisableRename(linkedWorkspace) || ReportUtils.isChatThread(this.props.report);
         const notificationPreference = this.props.translate(`notificationPreferencesPage.notificationPreferences.${this.props.report.notificationPreference}`);
         const shouldDisableWelcomeMessage = this.shouldDisableWelcomeMessage(linkedWorkspace);
-        const writeCapability = this.props.report.writeCapability || CONST.REPORT.WRITE_CAPABILITIES.ALL;
+        const writeCapability = ReportUtils.isAdminRoom(this.props.report)
+            ? CONST.REPORT.WRITE_CAPABILITIES.ADMINS
+            : this.props.report.writeCapability || CONST.REPORT.WRITE_CAPABILITIES.ALL;
+
         const writeCapabilityText = this.props.translate(`writeCapabilityPage.writeCapability.${writeCapability}`);
-        const shouldAllowWriteCapabilityEditing = lodashGet(linkedWorkspace, 'role', '') === CONST.POLICY.ROLE.ADMIN;
+        const shouldAllowWriteCapabilityEditing = lodashGet(linkedWorkspace, 'role', '') === CONST.POLICY.ROLE.ADMIN && !ReportUtils.isAdminRoom(this.props.report);
 
         return (
             <ScreenWrapper>

diff --git a/src/pages/settings/Report/WriteCapabilityPage.js b/src/pages/settings/Report/WriteCapabilityPage.js
@@ -14,6 +14,8 @@ import ROUTES from '../../../ROUTES';
 import * as Report from '../../../libs/actions/Report';
 import * as Expensicons from '../../../components/Icon/Expensicons';
 import themeColors from '../../../styles/themes/default';
+import * as ReportUtils from '../../../libs/ReportUtils';
+import FullPageNotFoundView from '../../../components/BlockingViews/FullPageNotFoundView';
 
 const propTypes = {
     ...withLocalizePropTypes,
@@ -38,24 +40,26 @@ function WriteCapabilityPage(props) {
 
     return (
         <ScreenWrapper includeSafeAreaPaddingBottom={false}>
-            <HeaderWithBackButton
-                title={props.translate('writeCapabilityPage.label')}
-                shouldShowBackButton
-                onBackButtonPress={() => Navigation.goBack(ROUTES.getReportSettingsRoute(props.report.reportID))}
-            />
-            <OptionsList
-                sections={[{data: writeCapabilityOptions}]}
-                onSelectRow={(option) => Report.updateWriteCapabilityAndNavigate(props.report, option.value)}
-                hideSectionHeaders
-                optionHoveredStyle={{
-                    ...styles.hoveredComponentBG,
-                    ...styles.mhn5,
-                    ...styles.ph5,
-                }}
-                shouldHaveOptionSeparator
-                shouldDisableRowInnerPadding
-                contentContainerStyles={[styles.ph5]}
-            />
+            <FullPageNotFoundView shouldShow={ReportUtils.isAdminRoom(props.report)}>
+                <HeaderWithBackButton
+                    title={props.translate('writeCapabilityPage.label')}
+                    shouldShowBackButton
+                    onBackButtonPress={() => Navigation.goBack(ROUTES.getReportSettingsRoute(props.report.reportID))}
+                />
+                <OptionsList
+                    sections={[{data: writeCapabilityOptions}]}
+                    onSelectRow={(option) => Report.updateWriteCapabilityAndNavigate(props.report, option.value)}
+                    hideSectionHeaders
+                    optionHoveredStyle={{
+                        ...styles.hoveredComponentBG,
+                        ...styles.mhn5,
+                        ...styles.ph5,
+                    }}
+                    shouldHaveOptionSeparator
+                    shouldDisableRowInnerPadding
+                    contentContainerStyles={[styles.ph5]}
+                />
+            </FullPageNotFoundView>
         </ScreenWrapper>
     );
 }