Skip to content

Commit

Permalink
Merge pull request #17794 from Expensify/OSBotify-cherry-pick-staging…
Browse files Browse the repository at this point in the history
…-17792

🍒 Cherry pick PR #17792 to staging 🍒
  • Loading branch information
OSBotify authored Apr 21, 2023
2 parents 85c99e9 + 2b05edf commit 4016eae
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 16 deletions.
4 changes: 2 additions & 2 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ android {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
multiDexEnabled rootProject.ext.multiDexEnabled
versionCode 1001030301
versionName "1.3.3-1"
versionCode 1001030302
versionName "1.3.3-2"
}

splits {
Expand Down
2 changes: 1 addition & 1 deletion ios/NewExpensify/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
</dict>
</array>
<key>CFBundleVersion</key>
<string>1.3.3.1</string>
<string>1.3.3.2</string>
<key>ITSAppUsesNonExemptEncryption</key>
<false/>
<key>LSApplicationQueriesSchemes</key>
Expand Down
2 changes: 1 addition & 1 deletion ios/NewExpensifyTests/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>1.3.3.1</string>
<string>1.3.3.2</string>
</dict>
</plist>
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "new.expensify",
"version": "1.3.3-1",
"version": "1.3.3-2",
"author": "Expensify, Inc.",
"homepage": "https://new.expensify.com",
"description": "New Expensify is the next generation of Expensify: a reimagination of payments based atop a foundation of chat.",
Expand Down
18 changes: 9 additions & 9 deletions src/libs/ReportUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -1703,6 +1703,14 @@ function canLeaveRoom(report, isPolicyMember) {
return true;
}

/**
* @param {string[]} participants
* @returns {Boolean}
*/
function isCurrentUserTheOnlyParticipant(participants) {
return participants && participants.length === 1 && participants[0] === sessionEmail;
}

/**
* Returns display names for those that can see the whisper.
* However, it returns "you" if the current user is the only one who can see it besides the person that sent it.
Expand All @@ -1711,7 +1719,7 @@ function canLeaveRoom(report, isPolicyMember) {
* @returns {string}
*/
function getWhisperDisplayNames(participants) {
const isWhisperOnlyVisibleToCurrentUSer = this.isCurrentUserTheOnlyParticipant(participants);
const isWhisperOnlyVisibleToCurrentUSer = isCurrentUserTheOnlyParticipant(participants);

// When the current user is the only participant, the display name needs to be "you" because that's the only person reading it
if (isWhisperOnlyVisibleToCurrentUSer) {
Expand All @@ -1721,14 +1729,6 @@ function getWhisperDisplayNames(participants) {
return _.map(participants, login => getDisplayNameForParticipant(login, !isWhisperOnlyVisibleToCurrentUSer)).join(', ');
}

/**
* @param {string[]} participants
* @returns {Boolean}
*/
function isCurrentUserTheOnlyParticipant(participants) {
return participants && participants.length === 1 && participants[0] === sessionEmail;
}

export {
getReportParticipantsTitle,
isReportMessageAttachment,
Expand Down

0 comments on commit 4016eae

Please sign in to comment.