Merge pull request #45186 from cretadn22/filter-paycheck-report

Filter out paycheck report on LHN
Expensify · Jul 10, 2024 · 3e164ed · 3e164ed
2 parents 98932a2 + 6152c07
commit 3e164ed
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 0 deletions.
diff --git a/src/CONST.ts b/src/CONST.ts
@@ -840,6 +840,8 @@ const CONST = {
             IOU: 'iou',
             TASK: 'task',
             INVOICE: 'invoice',
+            PAYCHECK: 'paycheck',
+            BILL: 'bill',
         },
         CHAT_TYPE: chatTypes,
         WORKSPACE_CHAT_ROOMS: {

diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts
@@ -5459,6 +5459,10 @@ function shouldReportBeInOptionList({
         return false;
     }
 
+    if (report?.type === CONST.REPORT.TYPE.PAYCHECK || report?.type === CONST.REPORT.TYPE.BILL) {
+        return false;
+    }
+
     // Include the currently viewed report. If we excluded the currently viewed report, then there
     // would be no way to highlight it in the options list and it would be confusing to users because they lose
     // a sense of context.

diff --git a/tests/unit/SidebarFilterTest.ts b/tests/unit/SidebarFilterTest.ts
@@ -280,6 +280,35 @@ xdescribe('Sidebar', () => {
             );
         });
 
+        it('filter paycheck and bill report', () => {
+            const report1: Report = {
+                ...LHNTestUtils.getFakeReport(),
+                type: CONST.REPORT.TYPE.PAYCHECK,
+            };
+            const report2: Report = {
+                ...LHNTestUtils.getFakeReport(),
+                type: CONST.REPORT.TYPE.BILL,
+            };
+            const report3: Report = LHNTestUtils.getFakeReport();
+            LHNTestUtils.getDefaultRenderedSidebarLinks(report1.reportID);
+            const reportCollectionDataSet: ReportCollectionDataSet = {
+                [`${ONYXKEYS.COLLECTION.REPORT}${report1.reportID}`]: report1,
+                [`${ONYXKEYS.COLLECTION.REPORT}${report2.reportID}`]: report2,
+                [`${ONYXKEYS.COLLECTION.REPORT}${report3.reportID}`]: report3,
+            };
+            return (
+                waitForBatchedUpdates()
+                    .then(() => Onyx.multiSet(reportCollectionDataSet))
+
+                    // Then the reports 1 and 2 are hidden and 3 is not
+                    .then(() => {
+                        const hintText = Localize.translateLocal('accessibilityHints.navigatesToChat');
+                        const optionRows = screen.queryAllByAccessibilityHint(hintText);
+                        expect(optionRows).toHaveLength(1);
+                    })
+            );
+        });
+
         // NOTE: This is also for #focus mode, should we move this test block?
         describe('all combinations of isArchived, isUserCreatedPolicyRoom, hasAddWorkspaceError, isUnread, isPinned, hasDraft', () => {
             // Given a report that is the active report and doesn't change