This repository has been archived by the owner on Sep 8, 2023. It is now read-only.
Breaking: Update hapi to v18 and use @hapi scoped packages #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonastanner
commented
Jun 7, 2019
| @@ -3,7 +3,6 @@ | |||
| const Test = require('tape'); | |||
| const Steerage = require('../lib'); | |||
| const Path = require('path'); | |||
| const Hapi = require('hapi'); | |||
There was a problem hiding this comment.
This did not seem to be used anymore since the earlier hapi v16->17 changes.
Thanks @tlivings ! What's the release process here? Do I need to do anything further, or you just need to merge in the PR? Thanks again 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Hapi to v18 - I went through all the breaking changes at hapijs/hapi#3871 and did not spot any potential issues.
npm run testpassed successfully on both Node v8 and v10