Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: more clean up #66

Merged
merged 1 commit into from
Nov 13, 2018
Merged

refactor: more clean up #66

merged 1 commit into from
Nov 13, 2018

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Nov 13, 2018 •
edited
Loading

General clean up

  • Require queries and don't default to empty list since that causes an exception
  • Return the filtered list from SubTypeMapper since all users were filtering anyway
  • Move model package
  • Fix some detekt issues

@smyrick smyrick requested a review from a team November 13, 2018 22:06
@amandaducrou amandaducrou merged commit d28248f into ExpediaGroup:master Nov 13, 2018
@smyrick smyrick deleted the refactor-v4 branch November 13, 2018 23:08
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
@smyrick @amandaducrou
refactor: more clean up (ExpediaGroup#66)
10f2f71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandaducrou amandaducrou amandaducrou approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smyrick @amandaducrou