feat: fastjson2 for serialization of GraphQLResponse and deserialization of GraphQLRequest #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelAndalon
force-pushed
the
feat/fastjson
branch
from
6b22e9f
to
bfa5505
Compare
samuelAndalon
added a commit
that referenced
this pull request
Oct 4, 2024
…ion of GraphQLRequest (#2040) [the previous integration of kotlinx-serialization](#1937) represented a performance improvement when deserializing requests, however, responses are still being deserialized with jackson, recently we found that fastjson2 is the [fastest serialization library for the jvm](https://github.com/fabienrenaud/java-json-benchmark). this PR adds an opt-in support for fastjson2 which provides an easy integration with springboot codecs, the serializer relies on the same jackson annotation, and just had to write a deserializer because of the polymorphic nature of GraphQLRequest and GraphQLReponse GraphQLRequest deserialization <img width="1156" alt="image" src="https://github.com/user-attachments/assets/8a1e56a2-0d6f-4118-904a-a5d584caac19"> GraphQLResponse serialization <img width="1161" alt="image" src="https://github.com/user-attachments/assets/cfa6c843-50de-42e2-8f8e-7722c722b048"> --------- Co-authored-by: Samuel Vazquez <samvazquez@expediagroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
the previous integration of kotlinx-serialization represented a performance improvement when deserializing requests, however, responses are still being deserialized with jackson, recently we found that fastjson2 is the fastest serialization library for the jvm.
this PR adds an opt-in support for fastjson2 which provides an easy integration with springboot codecs, the serializer relies on the same jackson annotation, and just had to write a deserializer because of the polymorphic nature of GraphQLRequest and GraphQLReponse
benchmark results
GraphQLRequest deserialization
GraphQLResponse serialization
