add support for application/graphql-response+json content type #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
reviewed
Mar 6, 2023
| @@ -45,8 +45,9 @@ class GraphQLRoutesConfiguration( | |||
|
|
|||
| (isEndpointRequest and isNotWebSocketRequest).invoke { serverRequest -> | |||
| val graphQLResponse = graphQLServer.execute(serverRequest) | |||
| val accept = serverRequest.headers().accept().find { it == MediaType.APPLICATION_JSON } ?: MediaType.APPLICATION_GRAPHQL_RESPONSE | |||
There was a problem hiding this comment.
since application/json is current behavior I'd keep it as default for the next release as well i.e.
Suggested change
| val accept = serverRequest.headers().accept().find { it == MediaType.APPLICATION_JSON } ?: MediaType.APPLICATION_GRAPHQL_RESPONSE | |
| val acceptMediaType = serverRequest.headers().accept().find { it.includes(MediaType.APPLICATION_GRAPHQL_RESPONSE) }?.let { MediaType.APPLICATION_GRAPHQL_RESPONSE } ?: MediaType.APPLICATION_JSON |
There was a problem hiding this comment.
Thank you your review!
I've changed as the above.
dariuszkuc
reviewed
Mar 6, 2023
| endpoint: String = "graphql", | ||
| streamingResponse: Boolean = true, | ||
| jacksonConfiguration: ObjectMapper.() -> Unit = {}, | ||
| acceptContentType: ContentType = ContentType("application", "graphql-response+json"), |
There was a problem hiding this comment.
we probably should wait for ktor 2.3.0 which includes ktorio/ktor@45b4ccd
how do we also provide a fallback to just use application/json if there is no match?
There was a problem hiding this comment.
OK. I removed support in ktor server from this PR.
I'll make another PR when ktor 2.3.0 is released. 👍
dariuszkuc
approved these changes
Mar 7, 2023
|
Thanks for the PR! |
dariuszkuc
added
changes: patch
This was referenced Aug 31, 2023
dariuszkuc
pushed a commit
that referenced
this pull request
Sep 6, 2023
…application/graphql-response+json (#1832) ### 📝 Description Most clients will request with `*/*` unless an any MediaType is specified. However, the `*/*` was not taken into account in current implementation. I change to keep `application/json` as default instead of `application/graphql-response+json`. ### 🔗 Related Issues #1831 #1573 #1699
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Based on the accept header, spring server respond either with
application/json(default) orapplication/graphql-response+jsonmedia type.🔗 Related Issues
#1573