Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small letter case fix #1484

Merged
merged 1 commit into from
Jul 16, 2022

Conversation

nikitakoselev
Copy link
Contributor

All other particles in headers are in small case, so "to" should be the same.
image

Also - smile, we created this contribution together with Eman Hammad, as part of our https://www.meetup.com/twosseng/
You can see the recording here: https://tinyurl.com/bdednj3x

All other particles in headers are small case, so "to" should be the same.
@tapaderster tapaderster merged commit fa443b0 into ExpediaGroup:master Jul 16, 2022
@tapaderster tapaderster added changes: patch Changes require a patch version type: documentation Documentation or test changes and removed changes: patch Changes require a patch version labels Jul 16, 2022
@ghost
Copy link

ghost commented Jul 18, 2022

Topic title was in title case, as it should be under Expedia's style guide. If you're going to go with the style of the subheaders, which isn't our style guide but would at least be consistent, then "Contribute" should be lower case, too.

dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
All other particles in headers are small case, so "to" should be the same.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Documentation or test changes
Development

Successfully merging this pull request may close these issues.

2 participants