Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update spring-boot version to 5.3.20 #1458

Conversation

samuelAndalon
Copy link
Contributor

@samuelAndalon samuelAndalon commented Jun 9, 2022

📝 Description

  1. The known Remote Code Execution in Spring Beans is identified in graphql-kotlin-spring-client.
    main already consumes 5.3.20

  2. Forcing usage of graphql-java:17.2 spring-boot-starter-parent:2.7.0 pulls graphql-java:18 and graphql-kotlin 5.x.x is not compatible with that version, when clients using spring-boot-starter-parent:2.7.0 and graphql-kotlin 5.x.x the build will trigger a resolution error to force them to use graphql-java:17.2

🔗 Related Issues

  1. Remote Code Execution identified in graphql-kotlin-spring-client 5.4.1. #1456
  2. Spring Startup: class java.lang.String cannot be cast to class graphql.schema.GraphQLDirective #1451

@dariuszkuc
Copy link
Collaborator

Should you also bump up spring boot to 2.6.8?

@samuelAndalon samuelAndalon requested a review from dariuszkuc June 9, 2022 18:42
@samuelAndalon samuelAndalon requested a review from dariuszkuc June 9, 2022 20:54
@samuelAndalon samuelAndalon merged commit feac99c into ExpediaGroup:5.x.x Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants