fix: willAddGraphQLTypeToSchema needs annotations from field #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meta union annotation
dariuszkuc
reviewed
May 4, 2022
...tor/src/main/kotlin/com/expediagroup/graphql/generator/internal/types/generateGraphQLType.kt
Outdated
Show resolved
Hide resolved
...tor/src/main/kotlin/com/expediagroup/graphql/generator/internal/types/generateGraphQLType.kt
Outdated
Show resolved
Hide resolved
samuelAndalon
approved these changes
May 4, 2022
dariuszkuc
added
changes: minor
samuelAndalon
pushed a commit
that referenced
this pull request
May 9, 2022
samuelAndalon
added a commit
that referenced
this pull request
May 9, 2022
* feat: support directives with the union annotation (#1424) * feat: support directives with the union annotation * CR comment * fix: willAddGraphQLTypeToSchema needs annotations from field (#1437) * feat: use withDirective * feat: update tests Co-authored-by: bherrmann2 <bherrmann@expedia.com> Co-authored-by: samvazquez <samvazquez@expedia.com>
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
When using the
@GraphQLUnionas a meta annotation, the KType isAnywhen the type for the field is being generated by reflection. The correct type is actually the annotation on the field with the@GraphQLUnionmeta annotation. In this case, the type passed to the hook needs to be that annotation since that is the class with other annotations on it, which could be needed by the hook.🔗 Related Issues