[client] support @include and @skip directives #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
added
changes: patch
|
Interestingly, when testing out the change with |
added 2 commits
January 13, 2022 01:05
When using `@skip`/`@include` directives underlying fields will not be available in the response (as opposed to be `null`). This breaks `kotlinx.serialization` (Jackson defaults to null) as it requires some default value to be present.
tapaderster
reviewed
Jan 13, 2022
| assertNotNull(UUID.fromString(simpleResponse)) | ||
|
|
||
| val included = response.data?.included | ||
| assertNull(included) |
tapaderster
approved these changes
Jan 13, 2022
1 task
1 task
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Update client generator logic to handle
@skipand@includedirectives. If directives are specified they will override nullability of the underlying field to always be nullable.🔗 Related Issues
Supersedes: #1327
Resolves: #1282