[client] support optional input for kotlinx serialization #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that using `@Required` annotation works on serialization and deserialization (https://github.com/Kotlin/kotlinx.serialization/blob/master/docs/basic-serialization.md#required-properties) giving us the correct behavior for handling optional input. This PR also cleans up corresponding serialization tests to ensure we have consistent serialization between Jackson and Kotlinx Serialization. Resolves: ExpediaGroup#1151
dariuszkuc
added
changes: patch
JaCoCo already filters Kotlin auto generated code by checking for the line numbers. It appears it does not work for static methods and since `kotlinx.serialization` does not apply `@Generated` annotation (another JaCoCo mechanism to skip analysis), auto generated `write\$Self` static method is included in coverage which singificantly lowers the code coverage. See Kotlin/kotlinx.serialization#961 for details
smyrick
approved these changes
Aug 30, 2021
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
…up#1250) * [client] support optional input for kotlinx serialization It appears that using `@Required` annotation works on serialization and deserialization (https://github.com/Kotlin/kotlinx.serialization/blob/master/docs/basic-serialization.md#required-properties) giving us the correct behavior for handling optional input. This PR also cleans up corresponding serialization tests to ensure we have consistent serialization between Jackson and Kotlinx Serialization. Resolves: ExpediaGroup#1151 * lower code coverage from auto generated code JaCoCo already filters Kotlin auto generated code by checking for the line numbers. It appears it does not work for static methods and since `kotlinx.serialization` does not apply `@Generated` annotation (another JaCoCo mechanism to skip analysis), auto generated `write\$Self` static method is included in coverage which singificantly lowers the code coverage. See Kotlin/kotlinx.serialization#961 for details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
It appears that using
@Requiredannotation works on serialization and deserialization (https://github.com/Kotlin/kotlinx.serialization/blob/master/docs/basic-serialization.md#required-properties) giving us the correct behavior for handling optional input.This PR also cleans up corresponding serialization tests to ensure we have consistent serialization between Jackson and Kotlinx Serialization.
🔗 Related Issues
Resolves: #1151