Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website ktor Subscriptions wrong url #1863

Closed
charlee-dev opened this issue Oct 8, 2023 · 2 comments
Closed

Website ktor Subscriptions wrong url #1863

charlee-dev opened this issue Oct 8, 2023 · 2 comments
Labels
type: bug Something isn't working

Comments

@charlee-dev
Copy link
Contributor

charlee-dev commented Oct 8, 2023 •
edited
Loading

On the Server/Subscriptions page link to the ktor subscriptions documentation takes us to the Spring Subscriptions documentation instead of Ktor one.

Link:
CleanShot 2023-10-08 at 23 51 24

Goes here:
CleanShot 2023-10-08 at 23 53 31

But it should go here:
CleanShot 2023-10-08 at 23 53 56
@charlee-dev charlee-dev added the type: bug Something isn't working label Oct 8, 2023
@dariuszkuc
Copy link
Collaborator

Contributions are always welcome :) Feel free to open up PR with a fix.

charlee-dev added a commit to charlee-dev/graphql-kotlin that referenced this issue Oct 9, 2023
@charlee-dev
fix: Ktor Subscriptions wrong url ExpediaGroup#1863
8319eaa
This was referenced Oct 9, 2023
Closed
Merged
dariuszkuc pushed a commit that referenced this issue Oct 9, 2023
@charlee-dev
fix: Ktor Subscriptions wrong url #1863 (#1865)
8648080 
### 📝 Description
Replaced Spring subscriptions URL with Ktor subscriptions.

### 🔗 Related Issues
#1863
@dariuszkuc
Copy link
Collaborator

resolved in #1865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dariuszkuc @charlee-dev