feat(generate-matrix): allow generated matrix to follow basic configuration and let github create combinations #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration and let github create combinations
danadajian
approved these changes
Oct 1, 2024
|
🎉 This PR is included in version 1.64.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
here, i'm trying to allow the consumer to get back a simpler version of the generated matrix strategy for extensibility.
matrix configurations docs
currently, we're returning an object with an
includekey that contains a list of objects, each with apathkey and apathvalue. this works for current use cases, but if we wanted to extend the matrix strategy to be able to, for example, run all provisioned paths over maybe some test and control set (maybe we're running all tests on the current node version and all tests on the next?), we could just use an object like{ paths: [path1, path2, path3, ...] }instead. here, i'm adding theuse_basic_matrix_configurationto return this instead of the current object structure. then, the consuming workflow could add in additional matrix specifications as desired.🔗 Related Issues