fix(manage-merge-queue): fix PR removal from queue #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -116,7 +116,7 @@ const getQueuedPullRequests = async (): Promise<PullRequestList> => { | |||
|
|
|||
| export const enableAutoMerge = async (pullRequestId: string, mergeMethod = 'SQUASH') => { | |||
| try { | |||
| return await octokitGraphql(` | |||
| await octokitGraphql(` | |||
There was a problem hiding this comment.
Why are we removing return here?
There was a problem hiding this comment.
Just wanted to remove cases of return await since it's kind of confusing to me 😂
There was a problem hiding this comment.
If we are not using the response returned, then yeah getting rid of return makes sense.
PoojaDonekal1294
approved these changes
Mar 26, 2024
|
🎉 This PR is included in version 1.48.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
removePrFromQueue()function was not being called and thus PRs were not being removed from the queue in certain scenarios.