fix(check-merge-safety): only set merge safety status to failure if it was previous success #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t was previously success
danadajian
reviewed
Oct 17, 2023
danadajian
reviewed
Oct 17, 2023
danadajian
reviewed
Oct 17, 2023
Comment on lines
+50
to
+57
| const { | ||
| head: { | ||
| ref, | ||
| user: { login: username } | ||
| } | ||
| } = pullRequest; | ||
| const truncatedRef = ref.length > maxBranchNameLength ? `${ref.substring(0, maxBranchNameLength)}...` : ref; | ||
| const truncatedBranchName = `${username}:${truncatedRef}`; |
There was a problem hiding this comment.
This is now duplicate code, could we extract a method?
danadajian
approved these changes
Oct 17, 2023
|
🎉 This PR is included in version 1.45.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
GitHub has a limit of 1000 statuses that can be set per commit. Since
check-merge-safetyruns so many times on large-scale repos, it lately has ended up accidentally hitting this limit, which fails the rest of the job so it doesn't finish setting statuses. Here, I check for an existing failure status before attempting to set a failure status. We could also perform the same check for success statuses, but that's not really a big problem right now; the issue is stale branches that are having the failure status set a thousand times.🔗 Related Issues