Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(approvals-satisfied): support collective approvals for shared code ownership #392

Merged
merged 8 commits into from
Jul 19, 2023
Merged

feat(approvals-satisfied): support collective approvals for shared code ownership #392

merged 8 commits into from
Jul 19, 2023

Conversation

danadajian
Copy link
Contributor

@danadajian danadajian commented Jul 19, 2023 •
edited
Loading

📝 Description

  • Updates the approvals-satisfied helper to treat CODEOWNERS paths with shared ownership differently. Instead of requiring N approvals from every single code owner team, it will now follow these rules:
    • Require N approvals from each team that has sole ownership of a directory
    • Require N collective approvals from individuals on teams that share ownership of a directory

This should be backwards compatible for usages that provide the teams input.

@danadajian danadajian requested a review from a team as a code owner July 19, 2023 14:24
@danadajian danadajian merged commit 8dd7ce3 into main Jul 19, 2023
4 checks passed
@danadajian danadajian deleted the improve-approval-check branch July 19, 2023 15:29
@danadajian
Copy link
Contributor Author

🎉 This PR is included in version 1.41.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danadajian