Skip to content

Commit

Permalink
feat(approvals-satisfied): add users support (#581)
Browse files Browse the repository at this point in the history
* feat(approvals-satisfied): add users support

* Update approvals-satisfied.ts

* Update approvals-satisfied.ts

* add users support

* add tests

* add tests

* update doc

* Update src/helpers/approvals-satisfied.ts

Co-authored-by: Dan Adajian <danadajian@gmail.com>

* fix bugs

* fix tests

* address comments

* address comments

* address comments

* address comments

* address comments

* address comments

* Update test/helpers/approvals-satisfied.test.ts

---------

Co-authored-by: Dan Adajian <danadajian@gmail.com>
  • Loading branch information
vsingal-p and danadajian authored Apr 2, 2024
1 parent 5c5ee61 commit c84a874
Show file tree
Hide file tree
Showing 38 changed files with 309 additions and 77 deletions.
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,9 @@ Each of the following helpers are defined in a file of the same name in `src/hel

### [approvals-satisfied](.github/workflows/approvals-satisfied.yml)

- Returns `true` if the PR has been approved by the specified GitHub team(s) and `false` otherwise
- If GitHub teams are omitted, uses `CODEOWNERS.md` to determine teams to use
- Returns `true` if the PR has been approved by the specified GitHub team(s) or user(s) and `false` otherwise
- If GitHub teams are omitted, uses `CODEOWNERS.md` to determine teams and/or users to use
- Note: If you are providing teams in input, full team name is NOT needed. i.e. `team-name` works and `org/team-name` is NOT needed

### [approve-pr](.github/workflows/approve-pr.yml)

Expand Down
3 changes: 3 additions & 0 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ inputs:
teams:
description: 'A list of github teams (newline separated)'
required: false
users:
description: 'A list of github users (newline separated)'
required: false
login:
description: 'A github user login'
required: false
Expand Down
2 changes: 1 addition & 1 deletion dist/0.index.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/101.index.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit c84a874

Please sign in to comment.