feat: Range query materialization #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpulipati29
commented
Mar 4, 2025
•
kpulipati29
commented
- Changes in online_write_batch to accommodate SortedFeaureView
- Changes in both batch and stream materialization process to pass the whole time series data (vs only the latest feature) in case of SortedFeaureView
piket
reviewed
Mar 5, 2025
| @@ -74,6 +76,10 @@ | |||
| " (?, ?, ?, ?) USING TTL {ttl};" | |||
| ) | |||
|
|
|||
| INSERT_TIME_SERIES_TEMPLATE = ( | |||
There was a problem hiding this comment.
We shouldn't call it "time series" since it can be used for any sorted set. I suggest going with "sorted features" to be consistent with the SortedFeatureView name.
kpulipati29
changed the title
|
You will also need to update relevant materialization files. Example here |
Oh yeah, let me check, thought the changes in spark files were enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.