This repository has been archived by the owner on Dec 17, 2021. It is now read-only.
Added Log4J for internal CT instance #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
massdosage
suggested changes
Mar 30, 2020
CHANGELOG.md
Outdated
| @@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [1.2.2] - TBD | |||
There was a problem hiding this comment.
Similar to other PR, let's go with 1.3.0
CHANGELOG.md
Outdated
| @@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [1.2.2] - TBD | |||
| ### Added | |||
| - Log4j Xml for internal Circus Train instance. | |||
There was a problem hiding this comment.
Suggested change
| - Log4j Xml for internal Circus Train instance. | |
| - Log4j XML for internal Circus Train instance. |
README.md
Outdated
| @@ -13,6 +13,7 @@ For more information please refer to the main [Apiary](https://github.com/Expedi | |||
| | aws\_region | AWS region to use for resources. | string | n/a | yes | | |||
| | cpu | The number of CPU units to reserve for the Shunting Yard container. Valid values can be 256, 512, 1024, 2048 and 4096. Reference: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-cpu-memory-error.html | string | `"1024"` | no | | |||
| | ct\_common\_config\_yaml | Common Circus Train configuration to be passed to internal Circus Train instance. It can be used, for example to configure Graphite for Circus Train. Refer to [Circus Train README](https://github.com/HotelsDotCom/circus-train/blob/master/README.md) for an exhaustive list of options supported by Circus Train. | string | n/a | yes | | |||
| | ct\_log4j\_xml | Log4j Xml file to be passed to internal Circus Train instance to control log level. | string | n/a | yes | | |||
There was a problem hiding this comment.
Suggested change
| | ct\_log4j\_xml | Log4j Xml file to be passed to internal Circus Train instance to control log level. | string | n/a | yes | | |
| | ct\_log4j\_xml | Log4j XML file to be passed to internal Circus Train instance to configure logging. | string | n/a | yes | |
variables.tf
Outdated
| @@ -67,6 +67,11 @@ variable "ct_common_config_yaml" { | |||
| type = "string" | |||
| } | |||
|
|
|||
| variable "ct_log4j_xml" { | |||
| description = "Log4j Xml file to be passed to internal Circus Train instance to control log level." | |||
There was a problem hiding this comment.
Suggested change
| description = "Log4j Xml file to be passed to internal Circus Train instance to control log level." | |
| description = "Log4j XML file to be passed to internal Circus Train instance to configure logging." |
max-jacobs
approved these changes
Mar 31, 2020
massdosage
approved these changes
Mar 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.