Use CMAKE_INSTALL_LOCALEDIR #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for reporting this. And even more thanks for providing a patch. I'm very pleased to accept your pull request. The Exiv2 project moved to Git with the release of v0.26 on 2017-04-28. You have the honour of the first "pull request". Congratulations and Thank You. And thanks for your observation that CMAKE_INSTALL_MANDIR is already in use. The CMake files have been an accumulation of contributions by about 10 engineers over about 10 years. Our nightly build uses CMake, so I have lots of confidence that it works. However, if you are a CMake fan, I would highly value any observations or contribution you'd care to make concerning our CMakeList.txt files. |
This was referenced Sep 24, 2017
This was referenced Mar 23, 2018
This was referenced Apr 4, 2018
This was referenced May 9, 2018
This was referenced Jun 11, 2018
This was referenced Mar 25, 2019
Closed
This was referenced Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change when using a prefix for cross setups like e.g. /usr/x86_64-pc-linux-gnu the architecture independent locale files end up in /usr/x86_64-pc-linux-gnu/share/locale instead of /usr/share/locale like it should be.
And you already use ${CMAKE_INSTALL_MANDIR in src/CMakeList.txt.